build: improve pnpm run generate performance (#242)

oxc-project · Nov 9, 2024 · 66f9fa1 · 66f9fa1
1 parent 64ab321
commit 66f9fa1
Show file tree

Hide file tree

Showing 3 changed files with 22 additions and 16 deletions.
diff --git a/scripts/config-generator.ts b/scripts/config-generator.ts
@@ -1,4 +1,4 @@
-import { writeFileSync } from 'node:fs';
+import { writeFile } from 'node:fs/promises';
 import path from 'node:path';
 import type { Rule } from './traverse-rules.js';
 import { camelCase, kebabCase, pascalCase } from 'scule';
@@ -40,7 +40,7 @@ export class ConfigGenerator {
     return map;
   }
 
-  public async generateRulesCode() {
+  public generateRulesCode() {
     console.log(`Generating config, grouped by ${this.rulesGrouping}`);
 
     const rulesGrouping = this.rulesGrouping;
@@ -78,9 +78,10 @@ export class ConfigGenerator {
     return code;
   }
 
-  public async generateRules(folderPath: string) {
-    const output = await this.generateRulesCode();
-    writeFileSync(
+  public async generateRules(folderPath: string): Promise<void> {
+    const output = this.generateRulesCode();
+
+    return writeFile(
       path.resolve(folderPath, `configs-by-${this.rulesGrouping}.ts`),
       output
     );

diff --git a/scripts/generate.ts b/scripts/generate.ts
@@ -23,9 +23,13 @@ if (!fs.existsSync(generateFolder)) {
   fs.mkdirSync(generateFolder);
 }
 
-for (const generator of [rulesGenerator, configGenerator]) {
-  generator.setRulesGrouping(RulesGrouping.SCOPE);
-  await generator.generateRules(generateFolder);
-  generator.setRulesGrouping(RulesGrouping.CATEGORY);
-  await generator.generateRules(generateFolder);
-}
+const promises = [rulesGenerator, configGenerator].map(
+  (generator) => async () => {
+    generator.setRulesGrouping(RulesGrouping.SCOPE);
+    await generator.generateRules(generateFolder);
+    generator.setRulesGrouping(RulesGrouping.CATEGORY);
+    await generator.generateRules(generateFolder);
+  }
+);
+
+await Promise.all(promises);
diff --git a/scripts/rules-generator.ts b/scripts/rules-generator.ts
@@ -1,4 +1,4 @@
-import { writeFileSync } from 'node:fs';
+import { writeFile } from 'node:fs/promises';
 import path from 'node:path';
 import type { Rule } from './traverse-rules.js';
 import { camelCase } from 'scule';
@@ -40,7 +40,7 @@ export class RulesGenerator {
     return map;
   }
 
-  public async generateRulesCode() {
+  public generateRulesCode() {
     console.log(`Generating rules, grouped by ${this.rulesGrouping}`);
 
     const rulesGrouping = this.rulesGrouping;
@@ -77,9 +77,10 @@ export class RulesGenerator {
     return code;
   }
 
-  public async generateRules(folderPath: string) {
-    const output = await this.generateRulesCode();
-    writeFileSync(
+  public generateRules(folderPath: string): Promise<void> {
+    const output = this.generateRulesCode();
+
+    return writeFile(
       path.resolve(folderPath, `rules-by-${this.rulesGrouping}.ts`),
       output
     );