Skip to content

Commit

Permalink
bugfix: ignore "security" scope (#183)
Browse files Browse the repository at this point in the history
  • Loading branch information
Sysix authored Oct 15, 2024
1 parent c6cbf39 commit 13cc44f
Show file tree
Hide file tree
Showing 4 changed files with 1 addition and 10 deletions.
2 changes: 1 addition & 1 deletion scripts/constants.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ export const VERSION_PREFIX = 'oxlint_v';
export const SPARSE_CLONE_DIRECTORY = 'crates/oxc_linter/src';

// these are the rules that don't have a direct equivalent in the eslint rules
export const ignoreScope = new Set(['oxc', 'deepscan']);
export const ignoreScope = new Set(['oxc', 'deepscan', 'security']);

// these are the mappings from the scope in the rules.rs to the eslint scope
// only used for the scopes where the directory structure doesn't reflect the eslint scope
Expand Down
3 changes: 0 additions & 3 deletions src/__snapshots__/rules-by-scope.spec.ts.snap
Original file line number Diff line number Diff line change
Expand Up @@ -1334,9 +1334,6 @@ exports[`contains all the oxlint rules 1`] = `
"rest-spread-spacing": [
0,
],
"security/api-keys": [
0,
],
"semi": [
0,
],
Expand Down
1 change: 0 additions & 1 deletion src/rules-by-category.ts
Original file line number Diff line number Diff line change
Expand Up @@ -338,7 +338,6 @@ const correctnessRules = {
'react/no-render-return-value': 'off',
'react/no-string-refs': 'off',
'react/void-dom-elements-no-children': 'off',
'security/api-keys': 'off',
'@typescript-eslint/no-duplicate-enum-values': 'off',
'@typescript-eslint/no-extra-non-null-assertion': 'off',
'@typescript-eslint/no-misused-new': 'off',
Expand Down
5 changes: 0 additions & 5 deletions src/rules-by-scope.ts
Original file line number Diff line number Diff line change
Expand Up @@ -363,10 +363,6 @@ const reactPerfRules = {
'react-perf/jsx-no-new-object-as-prop': 'off',
} as const;

const securityRules = {
'security/api-keys': 'off',
} as const;

const treeShakingRules = {
'tree-shaking/no-side-effects-in-initialization': 'off',
} as const;
Expand Down Expand Up @@ -482,7 +478,6 @@ export {
promiseRules,
reactRules,
reactPerfRules,
securityRules,
treeShakingRules,
unicornRules,
vitestRules,
Expand Down

0 comments on commit 13cc44f

Please sign in to comment.