Skip to content
This repository has been archived by the owner on Jun 5, 2024. It is now read-only.

Bugfix propfind response cut off #1032

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

lookacat
Copy link
Contributor

@lookacat lookacat commented Apr 1, 2022

We've fixed an issue where _parsePropNode in the dav client cut off subobjects of an object.

@lookacat lookacat marked this pull request as ready for review April 1, 2022 13:12
@pascalwengerter
Copy link
Contributor

Tried running the failing oCIS Providertests locally

Steps:

  • Start oCIS from around the commitid linked in .drone.env in the web repo (updated docker-compose and run docker compose up ocis)
  • Run PROVIDER_BASE_URL=https://host.docker.internal:9200 yarn test-provider:ocis which fails on Apple M1 chips since the @pact-foundation lib doesn't support it yet. I'm sure there's more env variables missing (further investigation in the .drone.star needed). The way to go here would be having them run successfully locally (= green tests) on master and then switch to this branch/PR and fix them

@sonarcloud
Copy link

sonarcloud bot commented Apr 5, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@lookacat
Copy link
Contributor Author

lookacat commented Apr 5, 2022

We won't continue here since it's too time consuming and we are not happy with the parsing overall.
Will discussed with:
#1036

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants