Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal to fix provider #3188

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Proposal to fix provider #3188

wants to merge 1 commit into from

Conversation

hannesa2
Copy link
Contributor

@hannesa2 hannesa2 commented Apr 6, 2021

It's a proposal to fix conflicting provider form logging lib owncloud/android-library#379
It simply accept the provider from ownCloud

@hannesa2 hannesa2 changed the title Fix provider Proposal to fix provider Apr 6, 2021
@jesmrec
Copy link
Collaborator

jesmrec commented Apr 8, 2021

Thanks for the fix.

In the code review, take in account this: owncloud/android-library#379 (comment)
@theScrabi @abelgardep @JuancaG05

@abelgardep
Copy link
Contributor

Hi @hannesa2, this solution does not fix the problem completely. Yes, we can build the app now, but it crashes when we try to share the logs. Could you take a look? Thanks!

    Process: com.owncloud.android, PID: 29054
    java.lang.IllegalArgumentException: Couldn't find meta-data for provider with authority com.owncloud.android.provider
        at androidx.core.content.FileProvider.parsePathStrategy(FileProvider.java:606)
        at androidx.core.content.FileProvider.getPathStrategy(FileProvider.java:579)
        at androidx.core.content.FileProvider.getUriForFile(FileProvider.java:417)
        at info.hannes.logcat.base.LogBaseFragment.sendLogContent(LogBaseFragment.kt:229)
        at info.hannes.logcat.base.LogBaseFragment.onOptionsItemSelected(LogBaseFragment.kt:176)```

@jesmrec jesmrec added p3-medium Normal priority and removed Sprint labels May 7, 2021
@jesmrec jesmrec modified the milestones: 2.18-current, backlog May 20, 2021
@jesmrec
Copy link
Collaborator

jesmrec commented May 30, 2023

@hannesa2 could you update this PR together with owncloud/android-library#379 (or this branch, more recent: https://github.com/owncloud/android-library/tree/optionalLiveLogging)

The idea is checking this asap over our newest master in order to merge it before moving the library to a new module.

Thanks a lot in advance

@hannesa2 hannesa2 mentioned this pull request Jun 4, 2023
@JuancaG05 JuancaG05 removed this from the backlog milestone May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants