Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve docs/output, helpful for 3rd parties #3523

Closed

Conversation

toni-sharpe
Copy link
Contributor

@toni-sharpe toni-sharpe commented Apr 20, 2024

Summary

Docker is persistent, as it should be, but, it can be problematic when one switches around projects which was what I did at my previous job. The instructions in the PR should conclusively "factory reset" docker so that OWID has no problem doing it's things.

When I first everything up it was more complicated and I feel this problem was because Docker for Desktop (D4D) doesn't report existing Docker images running via other tools. At my last place, which was a corporate company, we didn't pay the liscense for D4D and were given command line options that worked first time with little thought, whereas OWID clearly qualifies for free accounts.

new-session throws a duplicate session error if the TMux screen is closed without quitting, so an added line checks for the session and closes the grapher session before new-session is run. This means the TMux session can be closed properly with Ctrl+b, Q or by closing the terminal window in some other way. If sessions are found, it will only kill off grapher, so if grapher doesn't exist, that is reported but doesn't stop the file.

The MySQL infinite dot output might confuse people a bit. Looking at the message source and finding the dev/null destination suggests the result should be immediately be true but isn't for me for some reason. I'm looking at it while I'm here but not currently intending to change anything.

Testing

I think all one has to do is stop all the TMux stuff then try and run make again. Without the steps to remove all containers I think the same thing will happen, whether those containers are OWID D4D ones or some thing left over on a 3rd party machine. No, in fact running make up does work, and I think I may have improved it.

For that make up change: to test, just remove that commit and see how it works without.

I do have an old contracting laptop which is probably sitting with Dockers ready to pop up again, this would be a true test environment as it will be a closer analogue of my situation as a 3rd party contributor, pre-start. But it's one shot, so I've been incubating this problem while doing other things.

Condition of my local set-up

It works basically, as proven by the PRs I've submitted.

@toni-sharpe toni-sharpe marked this pull request as draft April 20, 2024 22:59
@toni-sharpe toni-sharpe marked this pull request as ready for review April 21, 2024 01:19
@toni-sharpe toni-sharpe changed the title WIP openinging PR early Improve docs to cover docker full reset, helpful for 3rd parties Apr 21, 2024
@toni-sharpe toni-sharpe force-pushed the docker-for-3rd-party-contributors branch 3 times, most recently from de4c7fe to 51e5f06 Compare April 26, 2024 18:12
@toni-sharpe toni-sharpe marked this pull request as draft May 9, 2024 16:29
@toni-sharpe toni-sharpe force-pushed the docker-for-3rd-party-contributors branch from e9b24aa to ccb1186 Compare May 20, 2024 15:25
@toni-sharpe toni-sharpe changed the title Improve docs to cover docker full reset, helpful for 3rd parties Improve docs/output, helpful for 3rd parties May 20, 2024
@toni-sharpe toni-sharpe force-pushed the docker-for-3rd-party-contributors branch from 5b0243e to 89ad915 Compare May 20, 2024 16:52
Toni Sharpe and others added 2 commits May 20, 2024 17:52
* how to start fresh with Docker on a machine that has trouble with containers hanging around.
* full reset instructions to remove everything and start up with Docker
* if the TMux window is closed in some other way than Ctrl+b, Q then `make up` will error, throwing duplicate session - this change checks for a session and removes the grapher session if it's found before going back to where the contributor was
@toni-sharpe toni-sharpe force-pushed the docker-for-3rd-party-contributors branch from 89ad915 to bdf27bf Compare May 20, 2024 16:55
@toni-sharpe
Copy link
Contributor Author

toni-sharpe commented May 23, 2024

Closing this, I think I was mostly learning stuff and that's led to understanding but no contribution.

The two docker commands for removing everything at the command line I think are handled more specifically by make down which is better. An update to the current instructions might be needed but that can be looked at separately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant