This repository has been archived by the owner on Sep 24, 2020. It is now read-only.
Give some analyzers more configs #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
issue is resolved |
ddmler
changed the title
K-Phoen
reviewed
Oct 15, 2016
| @@ -95,6 +99,9 @@ phpsa: | |||
| # Checks for use of deprecated functions and gives alternatives if available. | |||
| deprecated_functions: | |||
| enabled: true | |||
| check_5_3: true | |||
| check_5_5: true | |||
| check_7_1: true | |||
There was a problem hiding this comment.
Shouldn't we use the language_level setting to determine the checks that need to be done?
There was a problem hiding this comment.
I suggest to use language_level as @K-Phoen said, because using 100500 configuration is a stupid way
added 2 commits
November 4, 2016 11:55
ddmler
force-pushed
the
missing-docblock-config
branch
from
e60b132
to
6f14853
Compare
|
For now i removed deprecated functions/ini from this PR. |
|
Thanks @ddmler 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey!
Type: new feature
Link to issue: #234
This pull request affects the following components (please check boxes):
In raising this pull request, I confirm the following (please check boxes):
Small description of change:
MissingDocblock, Deprecated Functions/Ini have now extra settings to disable some parts of the analyzer.
What do you think about it?