This repository has been archived by the owner on Sep 24, 2020. It is now read-only.
Add analyzer descriptions #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
K-Phoen
reviewed
Oct 12, 2016
| @@ -9,6 +9,8 @@ | |||
|
|
|||
| class ArgumentUnpacking extends AbstractFunctionCallAnalyzer | |||
| { | |||
| const DESCRIPTION = 'Checks for use of `func_get_args()` and suggests the use of argument unpacking. (... operator)'; | |||
There was a problem hiding this comment.
Shouldn't this analyzer require PHP >= 5.6?
There was a problem hiding this comment.
Yes, I will push related changes @K-Phoen
|
Great work! 👍 Could you also add a commit to update the |
K-Phoen
approved these changes
Oct 12, 2016
I don't think that this command should dump this documentation. But we definitely could provide another command to dot it :) |
|
Thanks @ddmler! 🐟 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey!
Type:
Link to issue: #234
This pull request affects the following components (please check boxes):
In raising this pull request, I confirm the following (please check boxes):
Small description of change:
Added descriptions to analyzers, min php version for finalstatic analyzer, updated documentation.
Would be cool if dump-reference command could output the documentation file so we only have to update the texts once.