-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add efiBootloaderPath for dedicated server resource & update #755
Draft
bigbigbang
wants to merge
2
commits into
master
Choose a base branch
from
dedicated_server_add_efiBootloaderPath
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bigbigbang
requested review from
rbeuque74,
deathiop,
amstuta,
mxpetit,
yomovh and
marie-j
as code owners
October 17, 2024 13:56
bigbigbang
force-pushed
the
dedicated_server_add_efiBootloaderPath
branch
from
October 17, 2024 14:02
a751156
to
ac7d0b5
Compare
I think you forgot to update resource |
bigbigbang
force-pushed
the
dedicated_server_add_efiBootloaderPath
branch
2 times, most recently
from
October 24, 2024 14:21
e75cf46
to
ed94aa5
Compare
bigbigbang
force-pushed
the
dedicated_server_add_efiBootloaderPath
branch
2 times, most recently
from
October 24, 2024 16:01
8fcf9ba
to
e66d2e1
Compare
amstuta
reviewed
Oct 25, 2024
@@ -130,7 +137,7 @@ func TestAccDedicatedServer_basic(t *testing.T) { | |||
ImportStateVerify: true, | |||
ImportStateVerifyIdentifierAttribute: "service_name", | |||
ImportStateVerifyIgnore: []string{ | |||
"display_name", "order", "ovh_subsidiary", "plan", "plan_option", "template_name", | |||
"display_name", "order", "ovh_subsidiary", "plan", "plan_option", "template_name", "efi_bootloader_path", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this field is returned by the API and should thus be read when importing the resource, why would you ignore it ?
bigbigbang
force-pushed
the
dedicated_server_add_efiBootloaderPath
branch
9 times, most recently
from
October 28, 2024 14:46
d80bc85
to
fb32bda
Compare
bigbigbang
force-pushed
the
dedicated_server_add_efiBootloaderPath
branch
2 times, most recently
from
October 29, 2024 08:48
6aec2cc
to
0b469c8
Compare
bigbigbang
force-pushed
the
dedicated_server_add_efiBootloaderPath
branch
from
October 29, 2024 14:19
0b469c8
to
19f292b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add efiBootloaderPath for dedicated server resource & dedicated server update
Description
Possibility to GET and PUT the efi_bootloader_path on a dedicated server
Fixes #xx (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
make testacc TESTARGS="-run TestAccDedicatedServerDataSource_basic"
Test Configuration:
terraform version
: Terraform 1.6.6Checklist:
go mod vendor
if I added or modifygo.mod
file