feat: cloud provider instance amb

[maxime1907]

Description

Adds support for this route /cloud/project/{serviceName}/instance/{instanceId}/activeMonthlyBilling so that we can activate monthly billing instead of paying instances on a per hour basis.

Type of change

• New feature (non-breaking change which adds functionality)

How Has This Been Tested?

• Test A: make testacc TESTARGS="-run TestAccCloudProjectInstanceActiveMonthlyBilling_basic"

Test Configuration:

• Terraform version: terraform version: Terraform v1.3.9

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings or issues
• I have added acceptance tests that prove my fix is effective or that my feature works
• New and existing acceptance tests pass locally with my changes
• I ran succesfully go mod vendor if I added or modify go.mod file

[scraly]

Hi,
thanks for your PR :-)

As you can see in the contributing guide: https://github.com/ovh/terraform-provider-ovh/blob/master/CONTRIBUTING.md#coding-and-documentation-style
Can you rename/edit your code in order to "Name your resources and datasources according to the API endpoint"? :-)

For example if the API endpoint is /cloud/project/{serviceName}/instance/{instanceId}/activeMonthlyBilling, the name of the resource and/or datasource should be cloud_project_instance_activemonthlybilling.

Don't forget also to add documentation of the new resource and/or datasource, in website/ folder.

Thx

[scraly]

Any news? :-)

[amstuta]

See @scraly comments

[maxime1907]

Sorry i did not really have time this year, i will take a look at it in 2024