windows: fix argument handling in bin shim #9622

paperdave · 2024-03-25T18:26:13Z

What does this PR do?

there are some remaining failures in bunx test. it is incredibly flaky there so i need more time to look at

github-actions · 2024-03-25T18:55:37Z

❌ @paperdave 1 files with test failures on linux-x64-baseline:

test/integration/next/default-pages-dir/test/next-build.test.ts SIGTERM

View test output

^{#729ec67b784985321e9a160fba96af6380eb4e99}

github-actions · 2024-03-25T18:55:39Z

❌ @paperdave 3 files with test failures on linux-x64:

test/integration/next/default-pages-dir/test/dev-server.test.ts 1 failing
test/integration/next/default-pages-dir/test/next-build.test.ts SIGTERM
test/js/node/http2/node-http2.test.js 1 failing

View test output

^{#729ec67b784985321e9a160fba96af6380eb4e99}

github-actions · 2024-03-25T19:04:50Z

❌🪟 @paperdave, there are 15 test regressions on Windows x86_64

test\cli\install\bun-run-bunfig.test.ts
test\cli\install\bunx.test.ts
test\cli\install\bun-install.test.ts
test\cli\test\bun-test.test.ts
test\integration\sharp\sharp.test.ts
test\js\bun\console\console-iterator.test.ts
test\cli\install\registry\bun-install-registry.test.ts
test\js\bun\console\console-table.test.ts
test\js\bun\shell\commands\rm.test.ts
test\js\node\dns\node-dns.test.js
test\js\node\stream\node-stream.test.js
test\js\web\timers\setTimeout.test.js
test\js\web\fetch\body-stream.test.ts
test\js\web\workers\worker.test.ts
test\js\third_party\postgres\postgres.test.ts

Full Test Output

github-actions · 2024-03-25T19:06:35Z

❌ @paperdave 4 files with test failures on bun-darwin-aarch64:

test/integration/next/default-pages-dir/test/next-build.test.ts SIGTERM
test/js/bun/http/serve.test.ts 2 failing
test/js/bun/shell/leak.test.ts SIGTERM
test/js/bun/test/test-test.test.ts 1 failing

View test output

^{#729ec67b784985321e9a160fba96af6380eb4e99}

github-actions · 2024-03-25T19:11:31Z

❌ @paperdave 4 files with test failures on bun-darwin-x64:

test/integration/next/default-pages-dir/test/next-build.test.ts SIGTERM
test/js/bun/spawn/spawn.test.ts 2 failing
test/js/third_party/prisma/prisma.test.ts 2 failing
test/js/web/abort/abort.test.ts 1 failing

View test output

^{#729ec67b784985321e9a160fba96af6380eb4e99}

src/cli/run_command.zig

Co-authored-by: Jarred Sumner <[email protected]>

* Implement `fs.openAsBlob` * Use a function --------- Co-authored-by: Jarred Sumner <[email protected]>

Closes #8753

This reverts commit 20fce1a.

Co-authored-by: Jarred Sumner <[email protected]>

dylan-conway · 2024-03-27T05:03:28Z

test/cli/install/bunx.test.ts

@@ -95,10 +103,9 @@ it("should output usage if no arguments are passed", async () => {
 });

 it("should work for @scoped packages", async () => {


we should run this test with and without --bun, but it can be added later

dylan-conway

LGTM

paperdave and others added 4 commits March 25, 2024 11:08

awa

2361e1b

update v5

4b35db5

a

12104a3

[autofix.ci] apply automated fixes

442cd23

paperdave and others added 3 commits March 25, 2024 12:36

tarball

76e117f

a

d9674df

Merge branch 'main' into dave/win/shim5

c5bdf63

paperdave marked this pull request as draft March 25, 2024 20:55

paperdave and others added 9 commits March 25, 2024 17:00

a

9b519f9

blah

4fae44b

[autofix.ci] apply automated fixes

e3ea26c

bump

2ef978a

wah

3c6b5b3

[autofix.ci] apply automated fixes

8bd4630

farther

776e5c7

a

c34b6d5

[autofix.ci] apply automated fixes

cdd4253

Jarred-Sumner reviewed Mar 26, 2024

View reviewed changes

src/cli/run_command.zig Outdated Show resolved Hide resolved

paperdave and others added 7 commits March 26, 2024 17:56

im confused

578b40b

[autofix.ci] apply automated fixes

9b41644

Fix typo (#9623)

d6b54fe

Fix crash in Bun.escapeHTML (#9619)

a6bada6

Co-authored-by: Jarred Sumner <[email protected]>

Fixes #9610

8f3600a

Implement fs.openAsBlob (#9628)

01f1016

* Implement `fs.openAsBlob` * Use a function --------- Co-authored-by: Jarred Sumner <[email protected]>

Fix bun install -g not working on Docker

3533d34

Closes #8753

Electroid and others added 6 commits March 26, 2024 18:24

Revert "Fix bun install -g not working on Docker"

0edf86e

This reverts commit 20fce1a.

what happens if nonblocking tty (#9608)

2dabf13

Co-authored-by: Jarred Sumner <[email protected]>

merge

1bffcd3

Merge remote-tracking branch 'origin/main' into dave/win/shim5

a38e03f

a

0ec0b5e

blah

3c6108d

dylan-conway reviewed Mar 27, 2024

View reviewed changes

dylan-conway approved these changes Mar 27, 2024

View reviewed changes

dylan-conway marked this pull request as ready for review March 27, 2024 05:37

dylan-conway merged commit e808cdb into main Mar 27, 2024
26 of 31 checks passed

dylan-conway deleted the dave/win/shim5 branch March 27, 2024 05:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

windows: fix argument handling in bin shim #9622

windows: fix argument handling in bin shim #9622

paperdave commented Mar 25, 2024 •

edited

github-actions bot commented Mar 25, 2024 •

edited

github-actions bot commented Mar 25, 2024 •

edited

github-actions bot commented Mar 25, 2024 •

edited

github-actions bot commented Mar 25, 2024 •

edited

github-actions bot commented Mar 25, 2024 •

edited

dylan-conway Mar 27, 2024

dylan-conway left a comment

		@@ -95,10 +103,9 @@ it("should output usage if no arguments are passed", async () => {
		});

		it("should work for @scoped packages", async () => {

windows: fix argument handling in bin shim #9622

windows: fix argument handling in bin shim #9622

Conversation

paperdave commented Mar 25, 2024 • edited

What does this PR do?

github-actions bot commented Mar 25, 2024 • edited

github-actions bot commented Mar 25, 2024 • edited

github-actions bot commented Mar 25, 2024 • edited

❌🪟 @paperdave, there are 15 test regressions on Windows x86_64

github-actions bot commented Mar 25, 2024 • edited

github-actions bot commented Mar 25, 2024 • edited

dylan-conway Mar 27, 2024

Choose a reason for hiding this comment

dylan-conway left a comment

Choose a reason for hiding this comment

paperdave commented Mar 25, 2024 •

edited

github-actions bot commented Mar 25, 2024 •

edited

github-actions bot commented Mar 25, 2024 •

edited

github-actions bot commented Mar 25, 2024 •

edited

github-actions bot commented Mar 25, 2024 •

edited

github-actions bot commented Mar 25, 2024 •

edited