Do not skip tests in CI #9598
Open
Do not skip tests in CI #9598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❌ @Jarred-Sumner 5 files with test failures on linux-x64: |
|
❌ @Jarred-Sumner 4 files with test failures on linux-x64-baseline: |
|
❌ @Jarred-Sumner 7 files with test failures on bun-darwin-aarch64:
|
❌🪟 @Jarred-Sumner, there are 13 test regressions on Windows x86_64
|
|
❌ @Jarred-Sumner 6 files with test failures on bun-darwin-x64:
|
paperdave
reviewed
Mar 25, 2024
| import { Pool, Client } from "pg"; | ||
| import { parse } from "pg-connection-string"; | ||
| import postgres from "postgres"; | ||
|
|
||
| const CONNECTION_STRING = process.env.TLS_POSTGRES_DATABASE_URL; | ||
|
|
||
| const it = CONNECTION_STRING ? test : test.skip; | ||
| const it = CONNECTION_STRING ? test : test.skipIf(!isBunCI); |
There was a problem hiding this comment.
i agree that ci should run this, but from outside contributors this test will fail as the environment doesnt load. has this been fixed?
jdalton
reviewed
Mar 29, 2024
| import { MongoClient } from "mongodb"; | ||
|
|
||
| const CONNECTION_STRING = process.env.TLS_MONGODB_DATABASE_URL; | ||
|
|
||
| const it = CONNECTION_STRING ? test : test.skip; | ||
| const it = CONNECTION_STRING ? test : test.skipIf(!isBunCI); | ||
|
|
There was a problem hiding this comment.
Neat way to handle it aliases as test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
We should not be skipping tests in CI.
How did you verify your code works?
CI