Fix bundling for bun not using ascii_only #9571
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #9559
In printWithWriterAndPlatform(), its NewPrinter call was always setting ascii_only to false, but that means when bundling for the bun target, the code is not emitted as ascii only and there will be errors when running because it tries to run as latin1.
This code
When built with
bun build --target bun code.js
now emits:instead of:
It also works with
bun build --compile
.How did you verify your code works?
Added a regression test for the issue
It tests
bun build --target bun
and notbun build --compile
because compile takes a second and they're both the same issue.If Zig files changed:
bun-debug test test-file-name.test
)