Development environment documentation for openSUSE Tumbleweed #9479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 16, 2024 18:13
nellfs
changed the title
…butions in CMakeLists.txt" This reverts commit 93faed8.
paperdave
requested changes
Mar 17, 2024
| @@ -278,7 +278,7 @@ endif() | |||
| if(UNIX AND NOT APPLE) | |||
| execute_process(COMMAND grep -w "NAME" /etc/os-release OUTPUT_VARIABLE LINUX_DISTRO) | |||
|
|
|||
| if(${LINUX_DISTRO} MATCHES "NAME=\"(Arch|Manjaro|Artix) Linux\"\n") | |||
| if(${LINUX_DISTRO} MATCHES "NAME=\"(Arch|Manjaro|Artix) Linux\"|NAME=\"openSUSE Tumbleweed\"\n") | |||
There was a problem hiding this comment.
can you change this so that it is just NAME="(all the distros)" instead of an | on the outside, will make this simpler
There was a problem hiding this comment.
Unlike other distros, openSUSE does not get the "Linux" name after the distro name
paperdave
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
How did you verify your code works?
I made a change in
CMakeLists.txtto addopenSUSE Tumbleweedto the list of Linux distributions, I tested this PR on my computer and on a fresh virtual machine to make sure thatbun setupworks. 😊