shell: make sure proper .env is loaded in script runner #9448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❌ @zackradisic 4 files with test failures on linux-x64: |
|
❌ @Jarred-Sumner 5 files with test failures on bun-darwin-aarch64:
|
❌🪟 @Jarred-Sumner, there are 18 test regressions on Windows x86_64
|
|
❌ @zackradisic 6 files with test failures on bun-darwin-x64:
|
| const { stdout, stderr, exited } = Bun.spawn({ | ||
| cmd: [bunExe(), "run", "prod"], | ||
| cwd: package_dir, | ||
| stdio: ["pipe", "pipe", "pipe"], |
There was a problem hiding this comment.
Suggested change
| stdio: ["pipe", "pipe", "pipe"], | |
| stdio: ["ignore", "pipe", "pipe"], |
| const { stdout, stderr, exited } = Bun.spawn({ | ||
| cmd: [bunExe(), "prod"], | ||
| cwd: package_dir, | ||
| stdio: ["pipe", "pipe", "pipe"], |
There was a problem hiding this comment.
Suggested change
| stdio: ["pipe", "pipe", "pipe"], | |
| stdio: ["ignore", "pipe", "pipe"], |
| await writeFile(join(package_dir, ".env.development"), `AWESOME=development`); | ||
|
|
||
| const { stdout, stderr, exited } = Bun.spawn({ | ||
| cmd: [bunExe(), "run", "prod"], |
There was a problem hiding this comment.
Suggested change
| cmd: [bunExe(), "run", "prod"], | |
| cmd: [bunExe(), "--shell=bun", "run", "prod"], |
| @@ -831,3 +832,61 @@ function sentinelByte(buf: Uint8Array): number { | |||
| } | |||
| throw new Error("No sentinel byte"); | |||
| } | |||
|
|
|||
| test("shell as script runner propagates env vars: bun run <foo>", async () => { | |||
There was a problem hiding this comment.
this should be condensed into a test.each for the bun run permutation and the non-bun run permutation
|
I think this bug is actually the shell not loading environment variables, and this fix causes a different bug where it no longer loads .env files in bun run at the right time |
|
❌ @zackradisic 4 files with test failures on linux-x64-baseline: |
|
superceded by #9642 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9445