Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a helpful error message when the xcode SDK is newer than the current macOS version #9397

Merged
merged 1 commit into from Mar 13, 2024

Conversation

Jarred-Sumner
Copy link
Collaborator

What does this PR do?

Adds this warning (pretend instead of "14.4" it said "14.1"). I ran into this and it was very confusing that I had a later version of the macOS SDK than the currently installed version

image

How did you verify your code works?

Manually

Copy link
Collaborator

@paperdave paperdave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good.

@Jarred-Sumner Jarred-Sumner merged commit 9bda350 into main Mar 13, 2024
25 of 28 checks passed
@Jarred-Sumner Jarred-Sumner deleted the jarred/fix-mac-linking-issue branch March 13, 2024 21:34
Copy link

❌🪟 @Jarred-Sumner, there are 14 test regressions on Windows x86_64

  • test\bundler\bundler_npm.test.ts
  • test\cli\install\migration\migrate.test.ts
  • test\cli\run\env.test.ts
  • test\cli\run\run-process-env.test.ts
  • test\cli\run\transpiler-cache.test.ts
  • test\js\bun\http\bun-server.test.ts
  • test\js\bun\http\fetch-file-upload.test.ts
  • test\js\node\dns\node-dns.test.js
  • test\js\third_party\es-module-lexer\es-module-lexer.test.ts
  • test\js\third_party\esbuild\esbuild-child_process.test.ts
  • test\js\third_party\jsonwebtoken\claim-private.test.js
  • test\js\web\fetch\body-stream.test.ts
  • test\transpiler\template-literal.test.ts
  • test\js\web\workers\worker.test.ts

Full Test Output

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants