windows: make more windows tests pass #9370
Merged
+687
−318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❌ @paperdave 3 files with test failures on linux-x64-baseline: |
|
❌ @paperdave 2 files with test failures on linux-x64: |
|
❌ @paperdave 5 files with test failures on bun-darwin-aarch64: |
❌🪟 @paperdave, there are 14 test regressions on Windows x86_64
|
|
❌ @paperdave 3 files with test failures on bun-darwin-x64: |
jdalton
reviewed
Mar 14, 2024
jdalton
reviewed
Mar 14, 2024
paperdave
commented
Mar 22, 2024
| // powershell `install.ps1` was used to install. | ||
|
|
||
| const image_path = bun.windows.exePathW(); | ||
| const image_dirname = image_path[0..(std.mem.lastIndexOfScalar(u16, image_path, '\\') orelse unreachable)]; | ||
|
|
||
| if (!std.mem.endsWith(u16, image_dirname, comptime bun.strings.literal(u16, "\\bun\\bin"))) | ||
| if (!std.mem.endsWith(u16, image_dirname, comptime bun.strings.literal(u16, "bun\\bin"))) |
There was a problem hiding this comment.
.bun\bin but also handle some form of user-install where it is organized in a folder named bun
| const dir = try std.fs.cwd().makeOpenPath(dirname, .{ .access_sub_paths = true }); | ||
| break :brk bun.toLibUVOwnedFD(dir.fd); | ||
| var dir = try std.fs.cwd().makeOpenPath(dirname, .{ .access_sub_paths = true }); | ||
| errdefer dir.close(); |
dylan-conway
approved these changes
Mar 22, 2024
|
What tests does this fix? |
| @@ -17,7 +17,6 @@ | |||
| const { chmod, copyFile, lstat, mkdir, opendir, readlink, stat, symlink, unlink, utimes } = require("node:fs/promises"); | |||
| const { dirname, isAbsolute, join, parse, resolve, sep } = require("node:path"); | |||
|
|
|||
| const SafePromiseAll = Promise.all; | |||
| const PromisePrototypeThen = Promise.prototype.then; | |||
There was a problem hiding this comment.
The hilarious thing about this is .$then exists and so it's less safe than the actual
zackradisic
pushed a commit
that referenced
this pull request
Mar 25, 2024
* run-eval.test.ts * transpiler-cache.test.ts * node net * some open things * a * a * yikes * incredible * run it back * a * this code is what i like to call, incorrect * ok its all worng * remove an assertion that is wrong again * update test things and rebase * performance test * mark filesink with mkfifo as todo. see #8166 * hehe * not done * awa * fs test pass --------- Co-authored-by: Jarred Sumner <[email protected]> Co-authored-by: Jarred Sumner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
some changes to moving spawn({ cmd: [] }) to spawn([], {}) are done because our workspaces type definitions are broken :(
making use our
openin more places than before because i think our synchronous open is better than libuv'sFixes #6820