feat: bun --print
#9358
Merged
feat: bun --print
#9358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❌ @dylan-conway 4 files with test failures on bun-darwin-aarch64: |
|
❌ @dylan-conway 3 files with test failures on bun-darwin-x64: |
❌🪟 @dylan-conway, there are 14 test regressions on Windows x86_64
|
|
Instead of making GlobalObjectMethodTable non-const, couldn't we make Zig::GlobalObject a non-final class and then have Zig::EvalGlobalObject which would have the slightly different code path? |
|
❌ @dylan-conway 5 files with test failures on linux-x64-baseline: |
|
❌ @dylan-conway 6 files with test failures on linux-x64:
|
paperdave
reviewed
Mar 11, 2024
| @@ -537,7 +538,13 @@ pub const Arguments = struct { | |||
| } | |||
|
|
|||
| if (args.option("--port")) |port_str| { | |||
| opts.port = std.fmt.parseInt(u16, port_str, 10) catch return error.InvalidPort; | |||
| if (comptime cmd == .RunAsNodeCommand) { | |||
| // TODO: prevent `node --port <script>` from working | |||
There was a problem hiding this comment.
heh nice. i will keep this in mind for the CLI rewrite
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds
--printto runtime flags. This flag is the same asnode --print <script>, printing the result of the script, and also works with esm.fixes #5698
How did you verify your code works?
new and existing tests