chore: just a little bit of cleanup #9319
Merged
+19
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❌ @paperdave 1 files with test failures on linux-x64: |
|
❌ @paperdave 1 files with test failures on linux-x64-baseline: |
|
❌ @paperdave 2 files with test failures on bun-darwin-aarch64:
|
|
❌ @paperdave 1 files with test failures on bun-darwin-x64: |
❌🪟 @paperdave, there are 15 test regressions on Windows x86_64
|
| @@ -3278,7 +3278,7 @@ pub fn NewInterpreter(comptime EventLoopKind: JSC.EventLoopKind) type { | |||
| const err = switch (this.state) { | |||
| .expanding_redirect => this.state.expanding_redirect.expansion.state.err, | |||
| .expanding_args => this.state.expanding_args.expansion.state.err, | |||
| else => @panic("Invalid state"), | |||
| else => |t| std.debug.panic("Unexpected state .{s} in Bun shell", .{@tagName(t)}), | |||
There was a problem hiding this comment.
Output.panic, we should ban std.debug.panic
| @@ -6732,7 +6732,7 @@ pub fn NewInterpreter(comptime EventLoopKind: JSC.EventLoopKind) type { | |||
| pub fn onAsyncTaskDone(this: *Rm, task: *ShellRmTask) void { | |||
| var exec = &this.state.exec; | |||
| const tasks_done = switch (exec.state) { | |||
| .idle => @panic("Invalid state"), | |||
| .idle => @panic("Unexpected state .idle in Bun shell 'rm' builtin."), | |||
|
LGTM but @dylan-conway should look it over incase opinions about __has_install_script I feel like that name was deliberate |
|
The field should never be used directly was why it had double underscore, but there's also a comment saying this so LGTM |
dylan-conway
approved these changes
Mar 8, 2024
|
Maybe we should rename it to @“#has_install_scripts” |
|
or we could keep the name |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.