feat(cli): --filter flag #8185
Merged
feat(cli): --filter flag #8185
+1,635
−82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❌ @Jarred-Sumner 4 files with test failures on bun-darwin-aarch64:
|
|
❌ @Jarred-Sumner 3 files with test failures on linux-x64: |
|
❌ @Jarred-Sumner 3 files with test failures on linux-x64-baseline: |
|
❌ @gvilums 3 files with test failures on bun-darwin-x64:
|
|
❌ @Jarred-Sumner 8 files with test failures on bun-windows-x86_64-haswell
|
cirospaciari
pushed a commit
that referenced
this pull request
Apr 14, 2024
* Skeleton code for `bun run --workspace` * Update run_command.zig * implement directory traversal to find workspace root * finish --workspace implementation * clean up changes in run_command.zig * add workspace tests, update harness to handle nested dirs * [autofix.ci] apply automated fixes * basic filtering * [autofix.ci] apply automated fixes * working filter without patterns * update tests, filter mostly working * simplify package name parsing, commit tests * support filter even without workspace setup * move filter arg handling to separate source file * use bun.sys.chdir, match root package for scripts * fix exit code handling * ignore node_modules and directories starting with . in --filter * progress converting --filter to use iterators * convert filtering to use iterators * cleanup * implement DirEntry access method for glob (currently crashing) * cleanup and fixes * run js files in subprocess when filter flag passed * clean up dead code * fix fd leak in run_command.zig * [autofix.ci] apply automated fixes * fix issues after merge * use posix-spawn in runBinary, fix resource PATH variable resource leak * move filter argument to runtime category * fix test harness * add js and binary tests to filter-workspace * [autofix.ci] apply automated fixes * fix compile after merge * [autofix.ci] apply automated fixes * clean up filter-workspace test * [autofix.ci] apply automated fixes * fixes to running binaries * fix actually setting cwd_override * windows fixes * address some review comments * handle malformed JSON * add various tests * [autofix.ci] apply automated fixes * update docs for filter * [autofix.ci] apply automated fixes * reset tinycc commit * filtered run prototype * make pretty * implement abort handler (not working) * make prettier * prep for windows * windows path and printing fixes * implement log-style output (not tui) * fix issues when logging to file * revert a bunch of unecessary changes * cleanup * implement dependency order execution * detect circular dependencies, fix cancel hang * Fix `$PATH` * ignore dep order on loop, stream on linux, sort pkgs * support pre and post scripts * add more filter tests, print elapsed time * enable 'bun --filter' without run * fix harness after merge * [autofix.ci] apply automated fixes * print number of scripts we're waiting for * update docs, fix windows build * fix tests on windows * [autofix.ci] apply automated fixes * fix uninitialized memory * use terminal synchronized update sequences * Add skip list * Preallocate * Use current bun in tests --------- Co-authored-by: Jarred Sumner <[email protected]> Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> Co-authored-by: Jarred Sumner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds support for the
--filter <PATTERN>argument forbun run. See the pnpm docs for details.Note that currently only
--filter <name_pattern>and--filter ./<dir_pattern>are supported. Selecting dependencies or dependents of packages is not yet possible.Resolves #2232
Resolves #5207
How did you verify your code works?
Tests in
test/cli/run/filter-workspace.test.ts.