refactor: isolate allocators in bun.heap #16451
Open
+18,292
−2,693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fel1x-developer
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
My original plan was to put them under
bun.allocator.*, butsrc/allocators.zigalready exists which can confuse devs and zig's standard library's allocator are understd.heap.*, so I decided to put them underbun.heap.*From now on, allocators should be accessed by
bun.heap.*, not by@import("foo.zig")By doing this, vscode-zig detected few cases where
constcan be used in place ofvar, so there is definitely reason to do this.How did you verify your code works?