Support bundling HTML files and their js, css, and assets in Bun.build and bun build
#15940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Updated 10:09 AM PT - Dec 23rd, 2024
✅ @Jarred-Sumner, your commit 806c4b2 has passed in 🧪 try this PR locally: bunx bun-pr 15940 |
paperdave
requested changes
Dec 22, 2024
| // a <link rel="modulepreload" href="..." crossorigin> tag that | ||
| // points to the module or chunk's unique key so that we tell the | ||
| // browser to preload the user's code. | ||
| // We might also want to force <!DOCTYPE html> at the top of the file, but I'm not sure about that yet. |
There was a problem hiding this comment.
its fine to take no action re:doctype
the one person who wants to bundle quirks mode html can do so
|
awesome !!! but would you fix #5241 ? this block we switch to bun build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #4688
This lets you bundle HTML files in Bun. It uses
lol-htmlto parse and enqueue assets.Currently, elements matching the following selectors are considered for either bundling (if js/css) or copied when non-external:
script[src]link[rel='stylesheet'][href]link[as='style'][href]link[as='font'][href], link[type^='font/'][href]link[as='image'][href]link[as='video'][href], link[as='audio'][href]link[as='worker'][href]link[rel='manifest'][href]link[rel='icon'][href], link[rel='apple-touch-icon'][href]link:not([rel~='stylesheet']):not([rel~='modulepreload']):not([rel~='manifest']):not([rel~='icon']):not([rel~='apple-touch-icon'])[href]img[src]img[srcset]video[src]video[poster]audio[src]source[src]source[srcset]iframe[src]This list will probably change before this merges. It should probably be configurable.
How did you verify your code works?
There are tests.