Speculative fix for napi_set_property crash #10842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dylan-conway
reviewed
May 7, 2024
| Identifier identifier = keyProp.toPropertyKey(globalObject); | ||
| RETURN_IF_EXCEPTION(scope, napi_generic_failure); |
There was a problem hiding this comment.
I think we also need this exception check in napi_get_property before calling getIfPropertyExists
dylan-conway
reviewed
May 7, 2024
| JSValue jsValue = toJS(value); | ||
|
|
||
| object->put(object, globalObject, identifier, jsValue, slot); | ||
| RETURN_IF_EXCEPTION(scope, napi_generic_failure); | ||
| if (!object->put(object, globalObject, identifier, jsValue, slot)) { |
There was a problem hiding this comment.
Why was this check added? How is put returning false different from an exception thrown?
dylan-conway
reviewed
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
We have received many crash reports for
napi_set_property.The crash implies that
targetis set to undefined (08) and we are calling.getObject()on it, without properly validating that it is an objectNode.js' implementation of
napi_set_propertychecks target is an object viaCHECK_TO_OBJECT(env, context, obj, object);.This PR makes
napi_set_propertycheck that the property is an object first.We also disable strict mode when putting the property. Since Node doesn't default to strict mode, it's a good bet napi_set_property shouldn't either.
How did you verify your code works?
No tests