New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node:fs.readdir: should not fail even if folder contains self-referential symlinks #10752

Draft

nektro wants to merge 2 commits into main from revert-10750-revert-10679-nektro-patch-7

Contributor

nektro commented May 1, 2024

No description provided.


Revert "Revert "node:fs.readdir: should not fail even if folder conta…

b8e6266

…ins self…"

This reverts commit 23e4f60.

github-actions bot commented May 1, 2024 •

edited

❌ @nektro, your commit has failing tests :(

💪 7 failing tests Darwin AARCH64

test/bundler/bundler_npm.test.ts 1 failing
test/cli/install/bunx.test.ts 1 failing
test/cli/install/migration/complex-workspace.test.ts 6 failing
test/cli/install/migration/migrate.test.ts 1 failing
test/cli/install/overrides.test.ts 1 failing
test/integration/esbuild/esbuild.test.ts 1 failing
test/js/bun/http/serve.test.ts 1 failing

💻 2 failing tests Darwin x64 baseline

test/js/bun/http/serve.test.ts 1 failing
test/js/web/workers/worker.test.ts 1 failing

💻 2 failing tests Darwin x64

test/cli/install/registry/bun-install-registry.test.ts 4 failing
test/js/bun/http/serve.test.ts 1 failing

🐧🖥 1 failing tests Linux x64

test/js/node/child_process/child_process-node.test.js 1 failing

🪟💻 9 failing tests Windows x64 baseline

test/cli/install/bunx.test.ts 1 failing
test/cli/install/registry/bun-install-registry.test.ts 1 failing
test/integration/next-pages/test/dev-server-ssr-100.test.ts 1 failing
test/integration/next-pages/test/dev-server.test.ts 1 failing
test/integration/next-pages/test/next-build.test.ts 1 failing
test/js/bun/shell/bunshell.test.ts 1 failing
test/js/bun/shell/commands/rm.test.ts 1 failing
test/js/node/dns/node-dns.test.js 2 failing
test/js/node/fs/fs.test.ts 2 failing

🪟💻 9 failing tests Windows x64

test/cli/install/bunx.test.ts 1 failing
test/integration/esbuild/esbuild.test.ts 1 failing
test/integration/next-pages/test/dev-server-ssr-100.test.ts 1 failing
test/integration/next-pages/test/dev-server.test.ts 1 failing
test/integration/next-pages/test/next-build.test.ts 1 failing
test/js/bun/shell/bunshell.test.ts 1 failing
test/js/node/dns/node-dns.test.js 2 failing
test/js/node/fs/fs.test.ts 2 failing
test/js/web/fetch/fetch.tls.test.ts 1 failing


update test

4d8405d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment