Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

windows: fix flaky bunx test #10681

Closed
wants to merge 2 commits into from
Closed

windows: fix flaky bunx test #10681

wants to merge 2 commits into from

Conversation

nektro
Copy link
Contributor

@nektro nektro commented Apr 30, 2024

during extract_tarball, when ENOTEMPTY is received on windows the current behavior is to delete the target folder and try again. however when many instances are racing that are all installing the same dependency one of the other instances may write to the cache before the current one can; thus throwing ENOTEMPTY yet again. it is then better to notice this and move on to the next entry.

Copy link

github-actions bot commented Apr 30, 2024

@nektro, your commit has failing tests :(

💪 2 failing tests Darwin AARCH64

💻 1 failing tests Darwin x64 baseline

💻 2 failing tests Darwin x64

🐧💪 1 failing tests Linux AARCH64

🐧🖥 1 failing tests Linux x64

🪟💻 7 failing tests Windows x64 baseline

🪟💻 8 failing tests Windows x64

View logs

@nektro nektro closed this May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant