Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

code and reason are missing #10669

Merged
merged 6 commits into from May 14, 2024
Merged

code and reason are missing #10669

merged 6 commits into from May 14, 2024

Conversation

DaleSeo
Copy link
Contributor

@DaleSeo DaleSeo commented Apr 29, 2024 •
edited

What does this PR do?

code and reason is mssing from the type declaration of close.

Shot 2024-04-29 at 19 43 06@2x

  • Documentation or TypeScript types (it's okay to leave the rest blank in this case)
  • Code changes

How did you verify your code works?

@DaleSeo
Copy link
Contributor Author

DaleSeo commented May 14, 2024

@Electroid, could you please review this simple docs change?

@Electroid
Copy link
Contributor

Thanks!

@Electroid Electroid merged commit 301b0fd into oven-sh:main May 14, 2024
@DaleSeo DaleSeo deleted the patch-7 branch May 15, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@DaleSeo @Electroid