Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not run shell tests outside test scope #10199

Merged
merged 6 commits into from
Apr 16, 2024
Merged

Conversation

Jarred-Sumner
Copy link
Collaborator

What does this PR do?

@zackradisic when one of these shell tests fail, it prevents other tests from running

I'll let you take it from here to get the shell tests passing once again

How did you verify your code works?

Copy link
Contributor

github-actions bot commented Apr 12, 2024

Copy link
Contributor

github-actions bot commented Apr 12, 2024

Copy link
Contributor

github-actions bot commented Apr 12, 2024

Copy link
Contributor

github-actions bot commented Apr 12, 2024

@Jarred-Sumner
Copy link
Collaborator Author

@zackradisic tests still fail

Copy link
Contributor

github-actions bot commented Apr 14, 2024

✅ lint failures have been resolved. Thank you.

#fbd5eca1629342080399b918d35a6adce536d279

@zackradisic zackradisic force-pushed the jarred/tests-outside-test branch from 56f5a29 to c53b6a6 Compare April 15, 2024 15:49
@Jarred-Sumner Jarred-Sumner merged commit 291a39b into main Apr 16, 2024
27 of 32 checks passed
@Jarred-Sumner Jarred-Sumner deleted the jarred/tests-outside-test branch April 16, 2024 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants