-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not run shell tests outside test scope #10199
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ @zackradisic 3 files with test failures on linux-x64-baseline: |
❌ @zackradisic 3 files with test failures on linux-x64: |
❌ @zackradisic 4 files with test failures on bun-darwin-aarch64:
|
❌ @zackradisic 12 files with test failures on bun-windows-x86_64-haswell
|
❌ @zackradisic 4 files with test failures on bun-darwin-x64:
|
@zackradisic tests still fail |
✅ lint failures have been resolved. Thank you. |
zackradisic
force-pushed
the
jarred/tests-outside-test
branch
from
April 15, 2024 15:49
56f5a29
to
c53b6a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
@zackradisic when one of these shell tests fail, it prevents other tests from running
I'll let you take it from here to get the shell tests passing once again
How did you verify your code works?