Do not use always() in github actions

@Electroid this causes the tests to never cancel. GitHub has a concurrent actions limit which we easily reach. This causes CI to wait a long time before starting the job, wasting our time.

.github/workflows/ci.yml

@@ -134,7 +134,7 @@ jobs:
  cpu: nehalem
  canary: true
  linux-x64-test:
- if: ${{ inputs.run-id && always() || github.event_name == 'pull_request' }}
+ if: ${{ inputs.run-id || github.event_name == 'pull_request' }}
  name: Test linux-x64
  needs: linux-x64
  uses: ./.github/workflows/run-test.yml
@@ -145,7 +145,7 @@ jobs:
  runs-on: ${{ github.repository_owner == 'oven-sh' && 'namespace-profile-bun-ci-linux-x64' || 'ubuntu-latest' }}
  tag: linux-x64
  linux-x64-baseline-test:
- if: ${{ inputs.run-id && always() || github.event_name == 'pull_request' }}
+ if: ${{ inputs.run-id || github.event_name == 'pull_request' }}
  name: Test linux-x64-baseline
  needs: linux-x64-baseline
  uses: ./.github/workflows/run-test.yml
@@ -156,7 +156,7 @@ jobs:
  runs-on: ${{ github.repository_owner == 'oven-sh' && 'namespace-profile-bun-ci-linux-x64' || 'ubuntu-latest' }}
  tag: linux-x64-baseline
  linux-aarch64-test:
- if: ${{ inputs.run-id && always() || github.event_name == 'pull_request' && github.repository_owner == 'oven-sh'}}
+ if: ${{ inputs.run-id || github.event_name == 'pull_request' && github.repository_owner == 'oven-sh'}}
  name: Test linux-aarch64
  needs: linux-aarch64
  uses: ./.github/workflows/run-test.yml
@@ -167,7 +167,7 @@ jobs:
  runs-on: namespace-profile-bun-ci-linux-aarch64
  tag: linux-aarch64
  darwin-x64-test:
- if: ${{ inputs.run-id && always() || github.event_name == 'pull_request' }}
+ if: ${{ inputs.run-id || github.event_name == 'pull_request' }}
  name: Test darwin-x64
  needs: darwin-x64
  uses: ./.github/workflows/run-test.yml
@@ -178,7 +178,7 @@ jobs:
  runs-on: ${{ github.repository_owner == 'oven-sh' && 'macos-12-large' || 'macos-12' }}
  tag: darwin-x64
  darwin-x64-baseline-test:
- if: ${{ inputs.run-id && always() || github.event_name == 'pull_request' }}
+ if: ${{ inputs.run-id || github.event_name == 'pull_request' }}
  name: Test darwin-x64-baseline
  needs: darwin-x64-baseline
  uses: ./.github/workflows/run-test.yml
@@ -189,7 +189,7 @@ jobs:
  runs-on: ${{ github.repository_owner == 'oven-sh' && 'macos-12-large' || 'macos-12' }}
  tag: darwin-x64-baseline
  darwin-aarch64-test:
- if: ${{ inputs.run-id && always() || github.event_name == 'pull_request' }}
+ if: ${{ inputs.run-id || github.event_name == 'pull_request' }}
  name: Test darwin-aarch64
  needs: darwin-aarch64
  uses: ./.github/workflows/run-test.yml
@@ -200,7 +200,7 @@ jobs:
  runs-on: ${{ github.repository_owner == 'oven-sh' && 'namespace-profile-bun-ci-darwin-aarch64' || 'macos-12' }}
  tag: darwin-aarch64
  windows-x64-test:
- if: ${{ inputs.run-id && always() || github.event_name == 'pull_request' }}
+ if: ${{ inputs.run-id || github.event_name == 'pull_request' }}
  name: Test windows-x64
  needs: windows-x64
  uses: ./.github/workflows/run-test.yml
@@ -211,7 +211,7 @@ jobs:
  runs-on: windows
  tag: windows-x64
  windows-x64-baseline-test:
- if: ${{ inputs.run-id && always() || github.event_name == 'pull_request' }}
+ if: ${{ inputs.run-id || github.event_name == 'pull_request' }}
  name: Test windows-x64-baseline
  needs: windows-x64-baseline
  uses: ./.github/workflows/run-test.yml