Emit filter changes on filter removal

outl1ne · Feb 23, 2023 · e77cc5c · e77cc5c
1 parent 0434712
commit e77cc5c
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 5 deletions.
diff --git a/dist/js/entry.js b/dist/js/entry.js
diff --git a/resources/js/components/MultiselectFilter.vue b/resources/js/components/MultiselectFilter.vue
@@ -66,6 +66,7 @@ export default {
   data: () => ({
     options: [],
     isDropdownOpen: false,
+    hasRemoved: false,
     selectedOptions: [],
     isTouched: false,
   }),
@@ -99,6 +100,11 @@ export default {
       this.selectedOptions = this.isMultiselect ? value : [value];
 
       this.$nextTick(this.repositionDropdown);
+
+      if (this.hasRemoved) {
+        this.hasRemoved = false;
+        this.emitChanges();
+      }
     },
 
     handleClose() {
@@ -112,10 +118,7 @@ export default {
     },
 
     handleRemove() {
-      // Resolve issue where handleRemove is called before handleChange
-      this.$nextTick(() => {
-        if (!this.isDropdownOpen) this.emitChanges();
-      });
+      this.hasRemoved = true;
     },
 
     emitChanges() {