Remove Code Climate Smell #90
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #84 - Turn one method into many. - Wow this thing really needs tests with all of it's crazy edge cases. - This channel typing + type gaurds are a PITA + Crazy - TODO: `execute` can instantiate an instance of this class - That sould clean up the redundant dependency injection going on
PS: Purge still needs some tests 😬
ctsstc
commented
Oct 4, 2019
| @@ -3,7 +3,7 @@ | |||
| /* Basic Options */ | |||
| "target": "es6", /* Specify ECMAScript target version: 'ES3' (default), 'ES5', 'ES2015', 'ES2016', 'ES2017','ES2018' or 'ESNEXT'. */ | |||
| "module": "commonjs", /* Specify module code generation: 'none', 'commonjs', 'amd', 'system', 'umd', 'es2015', or 'ESNext'. */ | |||
| // "lib": [], /* Specify library files to be included in the compilation. */ | |||
| "lib": ["es2017"], /* Specify library files to be included in the compilation. */ | |||
There was a problem hiding this comment.
Add access to array.includes
I got my local specs passing,,, but then I forgot to update dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix up #84 🤞