-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#31 - Add Test Coverage #107
Merged
Merged
Commits on Apr 10, 2020
-
PS: I hope Bryce sleeps a little better knowing a repository out there in the world is slightly closer to 100% coverage. 🌛
Configuration menu - View commit details
-
Copy full SHA for 51fed73 - Browse repository at this point
Copy the full SHA 51fed73View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8a4c561 - Browse repository at this point
Copy the full SHA 8a4c561View commit details
Commits on Apr 11, 2020
-
## Changes - Use Dependency Injection on Commands for CommandClasses - Add some real tests for Commands - Fully covered! 🎉 - Core now injects an a client and commands into every command - Allows for reuse of commands in help function and other functions of the future :) - Commands now take an optional 3rd parameter that includes: - client - commands - Config - commandsPathGlob now lives in the config - commandTemplateFile has a new home - If we decide to later allow for ENV override on these it will be trivial. - These could probably be removed if they're only used in one place, but I also enjoy the dependency injection for testing purposes. Even the tests are using the real file paths This test is more like an integration test I think. This is fine. - Help command is now more readable and easier to test with dependency injection. - Full coverage ;)
Configuration menu - View commit details
-
Copy full SHA for a7e516e - Browse repository at this point
Copy the full SHA a7e516eView commit details -
I decided to remove the following from the config: - commandsPathGlob - commandTemplateFile They are only being used in a single place anyways. I also made sure they'll be easy to extract later if we ever need to inject them.
Configuration menu - View commit details
-
Copy full SHA for 7535920 - Browse repository at this point
Copy the full SHA 7535920View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8e02ac0 - Browse repository at this point
Copy the full SHA 8e02ac0View commit details -
Configuration menu - View commit details
-
Copy full SHA for cce729b - Browse repository at this point
Copy the full SHA cce729bView commit details -
Configuration menu - View commit details
-
Copy full SHA for ba5626b - Browse repository at this point
Copy the full SHA ba5626bView commit details -
SR: Add snapshot for help message
Also add some padding to match the original. Now that I can see what it looks like in the snap shot I can easily check :)
Configuration menu - View commit details
-
Copy full SHA for 219eb11 - Browse repository at this point
Copy the full SHA 219eb11View commit details -
Configuration menu - View commit details
-
Copy full SHA for cb8a998 - Browse repository at this point
Copy the full SHA cb8a998View commit details -
Seems to just be my stuff. I need to get my lint extension running on WSL :0!
Configuration menu - View commit details
-
Copy full SHA for a470b82 - Browse repository at this point
Copy the full SHA a470b82View commit details -
Configuration menu - View commit details
-
Copy full SHA for 47d3d36 - Browse repository at this point
Copy the full SHA 47d3d36View commit details -
A larger effort needs to be around this to makes all of these optional since not all commands will utilize all of these in the execute interface.
Configuration menu - View commit details
-
Copy full SHA for ad6e528 - Browse repository at this point
Copy the full SHA ad6e528View commit details
Commits on Apr 20, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 086e06d - Browse repository at this point
Copy the full SHA 086e06dView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.