issue #2228: refine config directive token parse; #4042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suzp1984
force-pushed
the
issue/2228-config-parse-end-of-line
branch
3 times, most recently
from
349f5cd
to
f74a308
Compare
winlinvip
reviewed
Apr 24, 2024
trunk/scripts/verify_confs.sh
Outdated
| @@ -0,0 +1,37 @@ | |||
| #!/bin/bash | |||
|
|
|||
| TRUNK_DIR=$(dirname -- "${BASH_SOURCE[0]}")/../ | |||
There was a problem hiding this comment.
No, the var store the path of trunk folder, the almost the source root of srs project, then doing the next steps.
run srs -t -c [conf file] for every file inside ${TRUNK_DIR}/conf/*.
winlinvip
reviewed
Apr 24, 2024
| @@ -223,7 +223,7 @@ VOID TEST(SampleTest, ContextTest) | |||
| cache[0] = cid; | |||
| } | |||
|
|
|||
| MockProtectedBuffer::MockProtectedBuffer() : size_(0), data_(NULL), raw_memory_(NULL) | |||
| MockProtectedBuffer::MockProtectedBuffer() : raw_memory_(NULL), size_(0), data_(NULL) | |||
There was a problem hiding this comment.
Yes, just to fix a compiler warning: the init order should be the declare orders in the header file.
srs/trunk/src/utest/srs_utest.hpp
Lines 112 to 117 in 37f0faa
suzp1984
force-pushed
the
issue/2228-config-parse-end-of-line
branch
3 times, most recently
from
39152ce
to
8b95506
Compare
make sure one directive token don't span more than two lines.
suzp1984
force-pushed
the
issue/2228-config-parse-end-of-line
branch
from
8b95506
to
99b0f64
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make sure one directive token don't span more than two lines.
try to fix #2228