fix(maven): return coordinates-only Package
on parsePackage
exception
#8471
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When analyzing a Maven project with a dependency on
opensymphony:quartz:1.6.0
, ORT does not include it in the packages list of the analyzer, but it is still present in thedependency_graphs.Maven.packages
. The reason for it turned out to be a lack of POM for the dependency in the Central (see [1]) causing an exception inMavenSupport.parsePackage
call.This PR fixes the issue by returning a coordinates-only
Package
fromgetOrElse
block instead ofnull
. Another way to fix this would be to return thatPackage
from theMavenSupport.parsePackage
itself. However,GradleDependencyHandler
seems to rely on the exception thrown by it, and other (potential) consumers might want to do that as well.[1] https://repo.maven.apache.org/maven2/opensymphony/quartz/1.6.0/