Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(helper-cli): Replace the custom runMain with CliktCommand.test #7492

Merged
merged 1 commit into from
Sep 13, 2023

Conversation

sschuberth
Copy link
Member

Note that a future version of clikt will also support a vararg for test for convenience 1. According code can be migrated once that version is available.

….test`

Note that a future version of clikt will also support a vararg for `test`
for convenience [1]. According code can be migrated once that version is
available.

[1]: ajalt/clikt#451

Signed-off-by: Sebastian Schuberth <[email protected]>
@sschuberth sschuberth requested a review from a team as a code owner September 13, 2023 07:04
@sschuberth sschuberth enabled auto-merge (rebase) September 13, 2023 07:04
@codecov
Copy link

codecov bot commented Sep 13, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (7e812fe) 68.01% compared to head (2e3249d) 68.01%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #7492   +/-   ##
=========================================
  Coverage     68.01%   68.01%           
  Complexity     2023     2023           
=========================================
  Files           339      339           
  Lines         16719    16719           
  Branches       2371     2371           
=========================================
  Hits          11371    11371           
  Misses         4363     4363           
  Partials        985      985           
Flag Coverage Δ
test 36.10% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@fviernau fviernau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@sschuberth sschuberth merged commit 2936cf1 into main Sep 13, 2023
21 checks passed
@sschuberth sschuberth deleted the more-clikt-test branch September 13, 2023 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants