Record the proper clone URL in the provenance #5852
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 57.74% // Head: 57.56% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #5852 +/- ##
============================================
- Coverage 57.74% 57.56% -0.18%
Complexity 2219 2219
============================================
Files 326 327 +1
Lines 19023 19092 +69
Branches 3735 3747 +12
============================================
+ Hits 10985 10991 +6
- Misses 6899 6963 +64
+ Partials 1139 1138 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
Note to myself: This raises the interesting test failure as with Subversion the tag is part of the URL. |
This increases reability and implicitly gives the formerly anonymous class a name so it can later be referred to. Slightly reorder functions while at it, so overridden function fo first and private functions go last. Signed-off-by: Sebastian Schuberth <[email protected]>
This is a fixup for 103a3c1 and fixes #5232. Signed-off-by: Sebastian Schuberth <[email protected]>
Signed-off-by: Sebastian Schuberth <[email protected]>
Earlier fallbacks might have tampered with the original URL (e.g. by stripping credentials), so the `RepositoryProvenance` should record the actual URL being used for creating the `WorkingTree`. Signed-off-by: Sebastian Schuberth <[email protected]>
sschuberth
force-pushed
the
provenance-clone-url
branch
from
1d169b7
to
8e2ea6a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please have a look at the individual commit messages for the details.