model: Introduce a concludedCopyrights field to package curations
#5680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sschuberth
force-pushed
the
declared-copyright-field
branch
from
e3da798
to
73cf1b3
Compare
sschuberth
changed the title
|
@sschuberth why is this a new PR? How does it differ from #5504? |
Codecov ReportBase: 57.73% // Head: 57.73% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #5680 +/- ##
=========================================
Coverage 57.73% 57.73%
Complexity 2187 2187
=========================================
Files 321 321
Lines 18987 18987
Branches 3730 3730
=========================================
Hits 10963 10963
Misses 6885 6885
Partials 1139 1139
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
sschuberth
changed the title
As I'm taking over @porsche-rbieniek's PRs it's more convenient for me to work on my own branches than his. I'll document the differences once this moves out of draft state. |
sschuberth
force-pushed
the
declared-copyright-field
branch
from
73cf1b3
to
e4bf624
Compare
sschuberth
changed the title
concludedCopyrights field to the data model
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
sschuberth
force-pushed
the
declared-copyright-field
branch
from
e4bf624
to
f2fd86d
Compare
The feature was a crude way to curate copyright statements by curating authors and enabling the addition of authors as copyrights (with a missing year even). That appraoch does not work if authors and copyrights need to stay separate, as e.g. by German law not every author is a copyright holder. So remove this feature in favor of an upcoming change that introduces proper and dedicated curations for concluded copyright statements. Signed-off-by: Sebastian Schuberth <[email protected]>
sschuberth
force-pushed
the
declared-copyright-field
branch
from
f2fd86d
to
b776860
Compare
Similar to the `concludedLicense` field, introduce a `concludedCopyrights` field that is to be set exclusively via a package curation [1] to override any detected copyright statements. Note that there is no such thing as *declared* copyright statements because package managers do not support them explicitly [1]. The concluded copyrights will get associated to all effective licenses; there currently is no way to curate a copyright statement for a specific license only. Behavior-wise this is no change compared to previous feature of curating authors and enabling the `addAuthorsToCopyrights` option. As a bonus, this fixes a subtle bug where previously packages might have been skipped in the scan if `authors` were set but `addAuthorsToCopyrights` was disabled. Resolves #4519. [1]: #5504 (comment) [1]: https://github.com/oss-review-toolkit/ort/blob/main/docs/config-file-curations-yml.md Signed-off-by: Rainer Bieniek <[email protected]> Signed-off-by: Sebastian Schuberth <[email protected]>
sschuberth
changed the title
concludedCopyrights field to the data modelconcludedCopyrights field to package curations
sschuberth
force-pushed
the
declared-copyright-field
branch
from
b776860
to
85f99a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In German law, the author and the copyright holder can be two separate
legal entities and therefore also need to be tracked separately.
Introduce a new field for declared copyrights that is now the primary
source for copyright holder information. Authors are still only used as
copyright holders if the
addAuthorsToCopyrightsoption is enabled.For now, all package manager implementations set empty declared
copyrights. Filling the declared copyrights is left as a future exercise
(also see 1). Currently, the only way to add declared copyrights is via
curations.
This change resolves #4519.
Signed-off-by: Rainer Bieniek [email protected]
Signed-off-by: Sebastian Schuberth [email protected]