ExperimentalScanner: Support skip options #4860
Conversation
Do not scan packages with a concluded license and non-empty authors if the `skipConcluded` scanner configuration option is set. Signed-off-by: Martin Nonnenmacher <[email protected]>
Support the `ScannerCommand` option to not scan excluded projects and packages. Signed-off-by: Martin Nonnenmacher <[email protected]>
mnonnenmacher
force-pushed
the
experimental-scanner-skip-concluded
branch
from
70d0e31
to
06967d9
Compare
| @@ -326,6 +326,16 @@ class ExperimentalScanner( | |||
| return nestedProvenanceScanResults | |||
| } | |||
|
|
|||
| private fun Collection<Package>.filterNotConcluded(): Collection<Package> = | |||
There was a problem hiding this comment.
Ah, I overlooked this: Input types should be as generic as possible (Collection) but output types as specific as possible, so the return type should stay a List.
There was a problem hiding this comment.
That was deliberate, because if I change the input type to Collection but keep the return type as List I would have to call toList() on the input if skipConcluded == false which would copy the list to a new ArrayList for no reason. And it's a private function after all, I think for those it's totally fine to be tailored to the use case of the class, that's why I didn't use Collection in the first place.
There was a problem hiding this comment.
Ok, in this case I'll leave it to you whether to use Collection or List in both places. Approving in any case.
Support the optional skipping of excluded packages and packages with concluded license.