Add support for package-lock.json
#210
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zkat
force-pushed
the
main
branch
3 times, most recently
from
84f604d
to
6970173
Compare
|
hey, just checking in. How's this going? :) |
|
Hi @zkat, I think it's almost done, I will finish it and submit it to review in a couple of weeks, i guess c: |
gabelluardo
force-pushed
the
json-lock-support
branch
2 times, most recently
from
da8cfde
to
29594fa
Compare
gabelluardo
force-pushed
the
json-lock-support
branch
from
29594fa
to
7e70f1d
Compare
|
hey @zkat can you check if it is correct? |
zkat
reviewed
Jul 7, 2023
| let mut deps_v1 = IndexMap::new(); | ||
| deps.insert("".to_string(), self.root.to_json()); | ||
| for (name, pkg) in packages { | ||
| deps.insert("node_modules/".to_string() + name.as_str(), pkg.to_json()); |
There was a problem hiding this comment.
This actually needs to be the path of the dependency on disk. Nested dependencies will look like node_modules/foo/node_modules/bar.
| deps.insert("".to_string(), self.root.to_json()); | ||
| for (name, pkg) in packages { | ||
| deps.insert("node_modules/".to_string() + name.as_str(), pkg.to_json()); | ||
| deps_v1.insert(name.as_ref(), pkg.to_json_v1()); |
There was a problem hiding this comment.
This needs to take into account nested dependencies.
|
hey @gabelluardo do you think you'll still pick up this PR? |
|
Hi @zkat sorry but I think I can't manage this in a short time |
|
No worries. Thanks for letting me know :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #188