Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qr code component challenge #155

Open
wants to merge 13 commits into
base: qr_code_component
Choose a base branch
from

Conversation

akinyiv
Copy link

@akinyiv akinyiv commented Jan 26, 2024

image

@akinyiv akinyiv changed the base branch from main to qr_code_component January 29, 2024 06:51
Copy link
Member

@almirsarajcic almirsarajcic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull from upstream. I recommend reading more about git and GitHub.

@akinyiv
Copy link
Author

akinyiv commented Jan 29, 2024 via email

Copy link
Member

@almirsarajcic almirsarajcic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

npm run format

Copy link
Member

@almirsarajcic almirsarajcic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now the tests are failing.

"scripts": {
"build": "node scripts/build.js",
"check-formatting": "npx prettier -c .",
"format": "npx prettier -w .",
"serve": "npm-run-all --parallel watch simple-autoreload-server",
"simple-autoreload-server": "npx autoreload-server -d ./public/ -p 3000 -b",
"test": "npm-run-all check-formatting build wdio-test",
"watch": "npm run build -- --watch",
"wdio-test": "npx wdio run wdio.conf.js"
}

Run the npm run test command locally and fix it until everything is passing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants