Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: github workflow vulnerable to script injection #554

Closed
wants to merge 1 commit into from

Conversation

diogoteles08
Copy link

Hi! I'm Diogo from Google's Open Source Security Team(GOSST) and I'm dropping by to suggest this small change that will enhance the security of your repository by preventing script injection attacks through your GitHub workflows.

In the piece of code I changed, you were directly using the value of a variable that comes from a user's input, so a malicious user could exploit that input and use it to run arbitrary code. By using an intermediate environment variable, the value of the expression is stored in memory, used as a variable and doesn't interact with the script generation process. This mitigates the script injection risks and also keeps your workflow running exactly as before.

You can find more information about this on this github documentation or in this gitguardian blogpost.

Cheers!

@jaeopt
Copy link
Collaborator

jaeopt commented Aug 21, 2024

@diogoteles08 Thanks for your contribution! We'll take a look.
If not done already, please sign the CLA - https://github.com/optimizely/swift-sdk/blob/master/CONTRIBUTING.md

@mikechu-optimizely
Copy link

This is going into our next sprint under ticket FSSDK-10665

@muzahidul-opti
Copy link
Contributor

@diogoteles08 this issue has been fixed with the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants