-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix broken cookie auth and allow app-based TOTP #5
Conversation
@macintoshhelper Thank you for your contribution. We are happy to merge your changes. Can you please add the documentation for the two environment variables? |
@macintoshhelper Main was out of date with the released npm version because I didn't have write access to the repo, but I created an npm version with my local version (however that was possible). It contains the |
@macintoshhelper I checked out your branch and tried to run the commands like the following:
What do I have to change so that it is working? |
@macintoshhelper Ok, I think it worked. I didn't have 2-factor authentication until now. Now an authentication token has been returned. |
Performing |
@macintoshhelper Here are the three possible responsive for a valid account.
Can you please update this PR one last time to:
Then we have all cases covered 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are my last remarks before merging and releasing
Fixes issues #2 #3 and an issue around rate limiting when
Cookie
andTsid
headers are missing.The issue in cookie parsing in #2 appears to be because of global
fetch
changes in Node.js, or a change in the HTTP responseRequires documentation on how to retrieve and set the new environment variables:
FIGMA_COOKIE
FIGMA_TSID