Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix part of #5343: Enable Code Coverage Analysis for many to one test target files #5459

Merged
merged 132 commits into from
Aug 7, 2024

Commits on Jun 28, 2024

  1. Code Coverage M1 edge case, added arg names to specifically pick the …

    …args to and make reordering possible
    Rd4dev committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    d1c07cd View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b26ac35 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    b89d9a8 View commit details
    Browse the repository at this point in the history
  4. Increasing the processTimeout to 10 minutes as coverage analysis take…

    … a long time causing TIMEOUT failures
    Rd4dev committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    23cba86 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    e24578e View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    96c2b74 View commit details
    Browse the repository at this point in the history

Commits on Jun 29, 2024

  1. Configuration menu
    Copy the full SHA
    349be2e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    300fb90 View commit details
    Browse the repository at this point in the history
  3. Reverting the changes just to check if these changes have any effect …

    …on the tests adding missed paranthesis
    Rd4dev committed Jun 29, 2024
    Configuration menu
    Copy the full SHA
    181e8b2 View commit details
    Browse the repository at this point in the history
  4. Re-introducing the changes while removing the ignore case check as we…

    … then convert them to uppercase
    Rd4dev committed Jun 29, 2024
    Configuration menu
    Copy the full SHA
    87926ad View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    718b065 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    c15d6e7 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    f417bda View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    70378d6 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    9dbd7be View commit details
    Browse the repository at this point in the history
  10. Using a simpler test and source file for sampleTestsDefaultFormat to …

    …see if it still fails (intended FAILURE output case)
    Rd4dev committed Jun 29, 2024
    Configuration menu
    Copy the full SHA
    f59c768 View commit details
    Browse the repository at this point in the history
  11. Using a simpler test and source file for scriptTestsMarkdownFormat to…

    … see if it still fails (intended FAILURE output case)
    Rd4dev committed Jun 29, 2024
    Configuration menu
    Copy the full SHA
    f5663d7 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    bab336e View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    2ee1bba View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    23b15b7 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    6f30dac View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    b391b1c View commit details
    Browse the repository at this point in the history
  17. Almost making compute affected tests execution time to 1 millisecond …

    …to see if it was reflected
    Rd4dev committed Jun 29, 2024
    Configuration menu
    Copy the full SHA
    f684951 View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    100d8f1 View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    4f2d93f View commit details
    Browse the repository at this point in the history
  20. Configuration menu
    Copy the full SHA
    9886da4 View commit details
    Browse the repository at this point in the history
  21. Configuration menu
    Copy the full SHA
    4f5d47c View commit details
    Browse the repository at this point in the history
  22. Configuration menu
    Copy the full SHA
    69d4583 View commit details
    Browse the repository at this point in the history
  23. Configuration menu
    Copy the full SHA
    e82f2fd View commit details
    Browse the repository at this point in the history
  24. Configuration menu
    Copy the full SHA
    a757fd9 View commit details
    Browse the repository at this point in the history
  25. Configuration menu
    Copy the full SHA
    f215839 View commit details
    Browse the repository at this point in the history
  26. Attempting with main caLL

    Rd4dev committed Jun 29, 2024
    Configuration menu
    Copy the full SHA
    d3105cd View commit details
    Browse the repository at this point in the history

Commits on Jun 30, 2024

  1. Intentionally causing delay in computeAffectedTestsTest to see if pro…

    …cessTimeout has any max limitation
    Rd4dev committed Jun 30, 2024
    Configuration menu
    Copy the full SHA
    f4b305f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d78df95 View commit details
    Browse the repository at this point in the history
  3. Completely cleaned up RunCoverageTest for checking with just one test…

    … will add delay later
    Rd4dev committed Jun 30, 2024
    Configuration menu
    Copy the full SHA
    c1bfbe1 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    043fcfc View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    9e3a16a View commit details
    Browse the repository at this point in the history
  6. Last commit overrided the processTimeout with 10 minutes while defaul…

    …ting to 10, now restricting to 1 minute with 200s sleep
    Rd4dev committed Jun 30, 2024
    Configuration menu
    Copy the full SHA
    f40793c View commit details
    Browse the repository at this point in the history
  7. Defaulting processTimeout to 1

    Rd4dev committed Jun 30, 2024
    Configuration menu
    Copy the full SHA
    8d6a10f View commit details
    Browse the repository at this point in the history
  8. Reverting all local changes

    Rd4dev committed Jun 30, 2024
    Configuration menu
    Copy the full SHA
    1a69432 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    9437d67 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    3787ea9 View commit details
    Browse the repository at this point in the history
  11. Importing kotlin coroutines

    Rd4dev committed Jun 30, 2024
    Configuration menu
    Copy the full SHA
    7ad2668 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    876152d View commit details
    Browse the repository at this point in the history
  13. Testing timeouts

    Rd4dev committed Jun 30, 2024
    Configuration menu
    Copy the full SHA
    0e99588 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    67e5fb9 View commit details
    Browse the repository at this point in the history
  15. Using longCommandExecutor

    Rd4dev committed Jun 30, 2024
    Configuration menu
    Copy the full SHA
    35e79da View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    2abf259 View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    3123047 View commit details
    Browse the repository at this point in the history
  18. Fixed the testRunCoverage_invalidFormat_throwsException by updating t…

    …o IllegalArgumentException
    Rd4dev committed Jun 30, 2024
    Configuration menu
    Copy the full SHA
    c6cf052 View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    f967850 View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2024

  1. Configuration menu
    Copy the full SHA
    f1f24f0 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    935662f View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    eab7f1a View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    4526517 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    8ec6b7c View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    fe642a6 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    f92e821 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    7132b7a View commit details
    Browse the repository at this point in the history
  9. Fixed testRunCoverage_localTestsMarkdownFormat_returnsCoverageData te…

    …st by adding appropriate local test content
    Rd4dev committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    5cffdc4 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    e38c940 View commit details
    Browse the repository at this point in the history
  11. Merge branch 'develop' of https://github.com/Rd4dev/oppia-android int…

    …o code_coverage_fix_edge_cases
    Rd4dev committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    a136d86 View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2024

  1. Configuration menu
    Copy the full SHA
    073599d View commit details
    Browse the repository at this point in the history
  2. Merge branch 'develop' of https://github.com/Rd4dev/oppia-android int…

    …o code_coverage_fix_edge_cases
    Rd4dev committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    fecb7d9 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    f9d1910 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    2e47173 View commit details
    Browse the repository at this point in the history

Commits on Jul 6, 2024

  1. Configuration menu
    Copy the full SHA
    a724461 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5f19114 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    9f9f9c6 View commit details
    Browse the repository at this point in the history
  4. Code cleanup - removed debugging statments, kept the mock multi cover…

    …age report list for reference / testing
    Rd4dev committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    5f9ae7a View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    45067f7 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    b3e4c0f View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    2bca7e0 View commit details
    Browse the repository at this point in the history
  8. Triggering CI due to error with repo fetching and insufficient write …

    …space mentioned in stack trace
    Rd4dev committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    c367957 View commit details
    Browse the repository at this point in the history
  9. Retriggering CI builds as the test pass locally and suspecting any do…

    …wnload errors in CI as mentioned in stack trace
    Rd4dev committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    1929c74 View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2024

  1. Configuration menu
    Copy the full SHA
    c5c11f6 View commit details
    Browse the repository at this point in the history
  2. Fixed the asynchronous flow, which was earlier not actually running a…

    …synchronously due to waiting for each coverage result
    Rd4dev committed Jul 7, 2024
    Configuration menu
    Copy the full SHA
    2ac7b04 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    5a57677 View commit details
    Browse the repository at this point in the history
  4. Added missed Deferred import

    Rd4dev committed Jul 7, 2024
    Configuration menu
    Copy the full SHA
    a09057b View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    49b8e0f View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    179e8a7 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    f82c35c View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    c38f2e8 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    a811947 View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2024

  1. Configuration menu
    Copy the full SHA
    e784657 View commit details
    Browse the repository at this point in the history
  2. Your commit message here

    Rd4dev committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    56809bf View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2024

  1. Retriggering ci checks to see if the error on downloading remote jdk …

    …11 are flake or not (they pass locally)
    Rd4dev committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    48c9d1b View commit details
    Browse the repository at this point in the history
  2. Specifying jdk version for TestBazelWorkspace build to see if this is…

    … causing any mismatched misconfiguration in ci (test pass locally)
    Rd4dev committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    4c87573 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    3d810b2 View commit details
    Browse the repository at this point in the history
  4. Fix Lint checks on indentation

    Rd4dev committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    595e9df View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2024

  1. Configuration menu
    Copy the full SHA
    4bc533f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    138a141 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    75e28e2 View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2024

  1. Configuration menu
    Copy the full SHA
    aaf3caf View commit details
    Browse the repository at this point in the history
  2. Updated processTimeout to set as standard 5 minutes and moved outCont…

    …ent specific to the test case
    Rd4dev committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    d3eb372 View commit details
    Browse the repository at this point in the history
  3. Merge branch 'code_coverage_fix_edge_cases' of https://github.com/opp…

    …ia/oppia-android into code_coverage_many_to_one_targets
    Rd4dev committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    9b5995e View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    6710f66 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    756bed8 View commit details
    Browse the repository at this point in the history
  6. Addition of dividing tests with shards did help with ci checks, now r…

    …emoving it to see if that is actually causing the issues (may be with idle times)
    Rd4dev committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    ab60123 View commit details
    Browse the repository at this point in the history
  7. Adding back shards since that significantly lessens the test run time…

    … most importantly helps with max idle run time issues
    Rd4dev committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    d25ea9c View commit details
    Browse the repository at this point in the history
  8. Merge branch 'code_coverage_fix_edge_cases' of https://github.com/opp…

    …ia/oppia-android into code_coverage_many_to_one_targets
    Rd4dev committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    8802b27 View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2024

  1. Merge branch 'develop' of https://github.com/Rd4dev/oppia-android int…

    …o code_coverage_fix_edge_cases
    Rd4dev committed Jul 13, 2024
    Configuration menu
    Copy the full SHA
    66a387e View commit details
    Browse the repository at this point in the history
  2. Merge branch 'code_coverage_fix_edge_cases' of https://github.com/opp…

    …ia/oppia-android into code_coverage_many_to_one_targets
    Rd4dev committed Jul 13, 2024
    Configuration menu
    Copy the full SHA
    50574ae View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    f170487 View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2024

  1. Merge branch 'develop' of https://github.com/Rd4dev/oppia-android int…

    …o code_coverage_many_to_one_targets
    Rd4dev committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    8955775 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    10d9acd View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2024

  1. Configuration menu
    Copy the full SHA
    be8ff1c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7d76b89 View commit details
    Browse the repository at this point in the history
  3. Trigger Build since ExplorationActiveTimeControllerTest seems to fail

    Might be a flaky test
    Rd4dev committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    c2eddfb View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2024

  1. Configuration menu
    Copy the full SHA
    ffe7768 View commit details
    Browse the repository at this point in the history
  2. Renaming the runWithCoverageAsync to runCoverageForTestTarget, update…

    …d the coverage proto description, renamed to findTestFiles, simplified conditional
    Rd4dev committed Jul 28, 2024
    Configuration menu
    Copy the full SHA
    8e88c35 View commit details
    Browse the repository at this point in the history

Commits on Jul 29, 2024

  1. Trying to find the coverage path with regex pattern as they mismatch

    Pushing it to see it through CI as local wsl seems broke and runs forever
    Rd4dev committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    c1f012c View commit details
    Browse the repository at this point in the history
  2. Save lobby before switching to a side branch to test permission error…

    … with writing coverage data
    Rd4dev committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    aa0de7f View commit details
    Browse the repository at this point in the history
  3. Trying to hit a certain line n number of times in different ways yet …

    …the count remains 1
    
    Makes me wonder if it just has binary values set to decide it, analysing few reports seems like they too exhibit the same behaviour for line coverages and branches have certain different int values but they seem to represent the branch
    Rd4dev committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    800ccda View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    ad611b8 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    84c5336 View commit details
    Browse the repository at this point in the history
  6. Merge branch 'develop' of https://github.com/Rd4dev/oppia-android int…

    …o code_coverage_many_to_one_targets
    Rd4dev committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    5561b4e View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    07184ee View commit details
    Browse the repository at this point in the history
  8. Fixes Missing Coverage Data Test Case

    Still the Failed to Retrieve Coverage File needs to be figured out and the code should be refactored to be more readable
    Rd4dev committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    3974ce0 View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2024

  1. Fixed the retrieve coverage failure test case :) by reproducing the s…

    …ame behaviour instead of brute forcing the scenario
    Rd4dev committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    360dc4b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    565f2f5 View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2024

  1. Updating the coverage missing test case while removing the job and re…

    …plicating the actual failure scenerio by not actually using a test file for its testing purposes
    Rd4dev committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    05a007b View commit details
    Browse the repository at this point in the history
  2. Clean up and changed the test case names to be more specific on what …

    …causes their failure
    Rd4dev committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    a3a661e View commit details
    Browse the repository at this point in the history
  3. Added validation to ensure exactly one unique value of filePath and f…

    …ileSha1Hash are present in the coverage report corresponding to one file for n:1 targets included
    Rd4dev committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    8a12cf4 View commit details
    Browse the repository at this point in the history
  4. Clean up of aggreagation code and replaced conditional error statment…

    …s with kotlin checks
    Rd4dev committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    e72179a View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    f00ebc6 View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2024

  1. Configuration menu
    Copy the full SHA
    824c406 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5ee99c0 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    372ae95 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    6499311 View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2024

  1. Merge branch 'develop' of https://github.com/Rd4dev/oppia-android int…

    …o code_coverage_many_to_one_targets
    Rd4dev committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    5e528fe View commit details
    Browse the repository at this point in the history
  2. Added the copy of local and shared test to ensure the multiple test f…

    …or a file do work properly
    Rd4dev committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    e72eec3 View commit details
    Browse the repository at this point in the history