-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Android Wiki] Fix Part of #2746 : Added Bazel Installations instructions for different Operating System #4926
[Android Wiki] Fix Part of #2746 : Added Bazel Installations instructions for different Operating System #4926
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@BenHenning PTAL, I added Bazel installation instructions mac m1/m2, make instrcutions more clear for other OS.
@adhiamboperes Can you please review on the Mac setup doc. @kkmurerwa Can you please have a look on Ubuntu/Fedora setup doc from your setup experinece feel free to give any suggestions. |
Hey @MohitGupta121. The Fedora part looks good. |
@kkmurerwa Thanks, you have any suggestions for Ubuntu? |
I haven't used Ubuntu that much so I can't really say a lot about it. But I believe the Wiki is sufficient for most Linux distros, especially the two that you focused on. You could add how to make Python 2 and jdk8 the default if that is required for Bazel to run. |
With our pending upgrade to Bazel 6.x, these requirements should change. Python 3 should be fine to use, and our dependencies are actually pushing us toward JDK 11 (and possibly later). @MohitGupta121 I can look especially at the Ubuntu part since that's my regular development environment (Linux Mint). Note that part of this may need to wait until #4886 is merged since that's a significant blocker in being able to do regular Bazel development. |
@BenHenning Okay Thanks, I will wait for the Bazel updation PR got merged first. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @MohitGupta121. Took a grammar/comprehensibility pass, PTAL.
Thanks @seanlip, PTAL, I make changes as per your review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The M1 instructions look good as per our prior tests.
Unassigning @adhiamboperes since they have already approved the PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MohitGupta121 Took another pass, thanks. Please read previous comments carefully, some issues are still present in the updated PR.
Okay Thanks @BenHenning |
Hi @MohitGupta121, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue. |
Hi @MohitGupta121, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@adhiamboperes PTAL, final review. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MohitGupta121, minor comments, looks good otherwise
Unassigning @adhiamboperes since the review is done. |
Hi @MohitGupta121, it looks like some changes were requested on this pull request by @adhiamboperes. PTAL. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@adhiamboperes PTAL, maked requested changes. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @MohitGupta121, this LGTM, thanks!
Explanation
Fix Part of #2746 : Added Bazel Installations instructions for different Operating System
Essential Checklist