Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android Wiki] Fix Part of #2746 : Added Bazel Installations instructions for different Operating System #4926

Merged
merged 27 commits into from
Jun 30, 2023
Merged

Conversation

MohitGupta121
Copy link
Member

@MohitGupta121 MohitGupta121 commented Mar 28, 2023

Explanation

Fix Part of #2746 : Added Bazel Installations instructions for different Operating System

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

Copy link
Member Author

@MohitGupta121 MohitGupta121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BenHenning PTAL, I added Bazel installation instructions mac m1/m2, make instrcutions more clear for other OS.

@MohitGupta121
Copy link
Member Author

@adhiamboperes Can you please review on the Mac setup doc.

@kkmurerwa Can you please have a look on Ubuntu/Fedora setup doc from your setup experinece feel free to give any suggestions.

@kkmurerwa
Copy link
Collaborator

Hey @MohitGupta121. The Fedora part looks good.

@MohitGupta121
Copy link
Member Author

@kkmurerwa Thanks, you have any suggestions for Ubuntu?

@kkmurerwa
Copy link
Collaborator

I haven't used Ubuntu that much so I can't really say a lot about it. But I believe the Wiki is sufficient for most Linux distros, especially the two that you focused on. You could add how to make Python 2 and jdk8 the default if that is required for Bazel to run.

@BenHenning
Copy link
Member

I haven't used Ubuntu that much so I can't really say a lot about it. But I believe the Wiki is sufficient for most Linux distros, especially the two that you focused on. You could add how to make Python 2 and jdk8 the default if that is required for Bazel to run.

With our pending upgrade to Bazel 6.x, these requirements should change. Python 3 should be fine to use, and our dependencies are actually pushing us toward JDK 11 (and possibly later).

@MohitGupta121 I can look especially at the Ubuntu part since that's my regular development environment (Linux Mint). Note that part of this may need to wait until #4886 is merged since that's a significant blocker in being able to do regular Bazel development.

@MohitGupta121
Copy link
Member Author

@BenHenning Okay Thanks, I will wait for the Bazel updation PR got merged first.

Copy link
Member

@seanlip seanlip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MohitGupta121. Took a grammar/comprehensibility pass, PTAL.

wiki/Bazel-Setup-Instructions-for-Linux.md Outdated Show resolved Hide resolved
wiki/Bazel-Setup-Instructions-for-Linux.md Outdated Show resolved Hide resolved
wiki/Bazel-Setup-Instructions-for-Linux.md Outdated Show resolved Hide resolved
wiki/Bazel-Setup-Instructions-for-Linux.md Outdated Show resolved Hide resolved
wiki/Bazel-Setup-Instructions-for-Linux.md Outdated Show resolved Hide resolved
wiki/Bazel-Setup-Instructions-for-Mac.md Outdated Show resolved Hide resolved
wiki/Bazel-Setup-Instructions-for-Mac.md Outdated Show resolved Hide resolved
wiki/Bazel-Setup-Instructions-for-Mac.md Outdated Show resolved Hide resolved
wiki/Bazel-Setup-Instructions-for-Mac.md Outdated Show resolved Hide resolved
wiki/Bazel-Setup-Instructions-for-Mac.md Outdated Show resolved Hide resolved
@seanlip seanlip assigned MohitGupta121 and unassigned seanlip Mar 29, 2023
@MohitGupta121
Copy link
Member Author

Thanks @seanlip, PTAL, I make changes as per your review.

Copy link
Collaborator

@adhiamboperes adhiamboperes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The M1 instructions look good as per our prior tests.

wiki/Bazel-Setup-Instructions-for-Mac.md Outdated Show resolved Hide resolved
@oppiabot
Copy link

oppiabot bot commented Mar 29, 2023

Unassigning @adhiamboperes since they have already approved the PR.

Copy link
Member

@seanlip seanlip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MohitGupta121 Took another pass, thanks. Please read previous comments carefully, some issues are still present in the updated PR.

wiki/Bazel-Setup-Instructions-for-Mac.md Outdated Show resolved Hide resolved
wiki/Bazel-Setup-Instructions-for-Mac.md Outdated Show resolved Hide resolved
wiki/Bazel-Setup-Instructions-for-Mac.md Outdated Show resolved Hide resolved
wiki/Bazel-Setup-Instructions-for-Mac.md Outdated Show resolved Hide resolved
wiki/Bazel-Setup-Instructions-for-Mac.md Show resolved Hide resolved
wiki/Bazel-Setup-Instructions-for-Mac.md Outdated Show resolved Hide resolved
wiki/Bazel-Setup-Instructions-for-Mac.md Outdated Show resolved Hide resolved
@seanlip seanlip assigned MohitGupta121 and unassigned seanlip Mar 30, 2023
@MohitGupta121
Copy link
Member Author

Okay Thanks @BenHenning

@oppiabot
Copy link

oppiabot bot commented Jun 18, 2023

Hi @MohitGupta121, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

@oppiabot oppiabot bot added the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Jun 18, 2023
@oppiabot oppiabot bot removed the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Jun 18, 2023
@oppiabot
Copy link

oppiabot bot commented Jun 25, 2023

Hi @MohitGupta121, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

@oppiabot oppiabot bot added the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Jun 25, 2023
@oppiabot oppiabot bot removed the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Jun 26, 2023
Copy link
Member Author

@MohitGupta121 MohitGupta121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adhiamboperes PTAL, final review. Thanks!

Copy link
Collaborator

@adhiamboperes adhiamboperes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MohitGupta121, minor comments, looks good otherwise

wiki/Bazel-Setup-Instructions-for-Mac.md Outdated Show resolved Hide resolved
wiki/Bazel-Setup-Instructions-for-Mac.md Show resolved Hide resolved
wiki/Bazel-Setup-Instructions-for-Mac.md Outdated Show resolved Hide resolved
wiki/Bazel-Setup-Instructions-for-Mac.md Outdated Show resolved Hide resolved
@oppiabot
Copy link

oppiabot bot commented Jun 29, 2023

Unassigning @adhiamboperes since the review is done.

@oppiabot
Copy link

oppiabot bot commented Jun 29, 2023

Hi @MohitGupta121, it looks like some changes were requested on this pull request by @adhiamboperes. PTAL. Thanks!

Copy link
Member Author

@MohitGupta121 MohitGupta121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adhiamboperes PTAL, maked requested changes. Thanks!

Copy link
Collaborator

@adhiamboperes adhiamboperes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @MohitGupta121, this LGTM, thanks!

@adhiamboperes adhiamboperes merged commit d049a5a into oppia:develop Jun 30, 2023
@MohitGupta121 MohitGupta121 deleted the bazel_installation_wiki branch June 30, 2023 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants