Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix part of #2691: Add diagnostics to investigate issues with compute affected targets #2847

Closed
wants to merge 1 commit into from

Conversation

BenHenning
Copy link
Member

Fix part of #2691.

Add extra diagnostic output to investigate issues with the compute affected targets workflow.

See #2691 (comment) for specifics on the issue being investigated here.

Add extra diagnostic output to investigate issues with the compute affected targets workflow.
@BenHenning BenHenning enabled auto-merge (squash) March 7, 2021 01:43
@BenHenning BenHenning changed the title Fix part of #2691: Add diagnostics to investigate issues with compute affected targets [RunAllTests] Fix part of #2691: Add diagnostics to investigate issues with compute affected targets Mar 7, 2021
@BenHenning BenHenning closed this Mar 7, 2021
auto-merge was automatically disabled March 7, 2021 01:43

Pull request was closed

@BenHenning
Copy link
Member Author

Restart CI to run all tests to demonstrate the new behavior.

@BenHenning BenHenning reopened this Mar 7, 2021
@BenHenning
Copy link
Member Author

Ah. Oops--the updated workflow specifically doesn't execute when [RunAllTests] is present. :)

@BenHenning BenHenning changed the title [RunAllTests] Fix part of #2691: Add diagnostics to investigate issues with compute affected targets Fix part of #2691: Add diagnostics to investigate issues with compute affected targets Mar 7, 2021
@BenHenning
Copy link
Member Author

Better diagnostics were added in #3025 making this unnecessary for now.

@BenHenning BenHenning closed this Mar 31, 2021
@BenHenning BenHenning deleted the compute-affected-targets-diagnostics branch March 31, 2021 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants