Fix #1762, #2704: Highlight Correct MenuItem after cancelling ExitProfileDialog

[prayutsu]

Explanation

Fixes #1762, and fixes #2704 -
Navigation Drawer now highlights the correct menu Item after canceling the ExitProfileDialog, and also after pressing the back button (when some activity is opened from the navigation drawer).

Manual testing video -
https://user-images.githubusercontent.com/54636525/107812250-6ceda380-6d95-11eb-9d46-5dafb44838c2.mp4

Tests passing on ESPRESSO-

New test cases being ignored on Robolectric-

Checklist

• The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
• The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
• The PR follows the style guide.
• The PR does not contain any unnecessary auto-generated code from Android Studio.
• The PR is made from a branch that's not called "develop".
• The PR is made from a branch that is up-to-date with "develop".
• The PR's branch is based on "develop" and not on any other branch.
• The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

[prayutsu]

Screenrecorder-2021-02-09-21-20-49-293.mp4

Now we are facing only 1 bug-

1. Go to Administrator Controls
2. Open NavDrawer and click on Switch Profile
3. Change the configuration of the device
4. The Switch Profile Item gets unchecked and Administrator Controls gets checked.

[BenHenning]

Honestly from a user perspective I think this looks quite solid @prayutsu. The scenario you described is quite an edge case, and I'm not even sure it can be considered a bug. It does have slight inconsistency with the other configuration change scenarios, but it still seems arguably 'correct' in the context in which it's observed (e.g. you're still in the admin controls page).

[BenHenning]

Thanks @prayutsu. This is definitely moving toward the right solution. Just have a few specific thoughts on the exact mechanism being built into the navigation drawer presenter. PTAL.

[rt4914]

@prayutsu Just found another issue filing this and do not solve this in this PR. #2728

Thanks.

[rt4914]

Forgot about my suggestions because of issue filing. Blocking this PR for nit changes.

[rt4914]

LGTM, thanks.

[anandwana001]

LGTM

[prayutsu]

[If @chrk2205 do not have any suggestions, then @anandwana001 can merge this PR.

[chrk2205]

LGTM

[prayutsu]

Thanks, everyone for reviewing the PR!!

[rt4914]

@BenHenning and @anandwana001 Some Optional tests are failing so should be merge in this case or not?

[BenHenning]

@rt4914 Optional tests can be partly ignored (which is why they're being kept optional). We don't need to block submission on them yet, but we should ensure new breakages are fixed in PRs where we can spot them. This isn't as perfect as requiring the tests yet, but we will need to wait a few weeks before we can mark them as required.

[BenHenning]

The failures seem like known flakes that are outside our codebase & need more investigating, plus one apparent issue with the compute affected targets PR process: https://github.com/oppia/oppia-android/pull/2671/checks?check_run_id=1908497857. Adding this to #2691.

[BenHenning]

Re-running with latest develop & enabling auto-merge.

[rt4914]

@BenHenning Thanks.