-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: primary-resouce is created in wrong place. #6872
fix: primary-resouce is created in wrong place. #6872
Conversation
5169f1a
to
2bd92d1
Compare
2bd92d1
to
8fcbc85
Compare
Hi @rashmigottipati @oceanc80 , I wonder if any of you have time to check my PR? Thanks a lot. |
Hi @rashmigottipati @oceanc80 , please advise how to proceed in order for this PR to be merged. I will appreciate it. |
@holyspectral Can you rebase your PR since there are failing tests? |
When deployed with helm-operator, the primary custom resource would randomly get assigned "operator-sdk/primary-resource" and "operator-sdk/primary-resource-type" annotations. This commit fixes the issue. Signed-off-by: Sam Wang (holyspectral) <[email protected]>
8fcbc85
to
0046acb
Compare
@acornett21 thanks! I've rebased my PR, but the sanity/sanity still fails due to |
Description of the change:
This PR fixes the issue where the primary custom resource would randomly get assigned "operator-sdk/primary-resource" and "operator-sdk/primary-resource-type" annotations when helm-operator is used.
Motivation for the change:
We use helm operator to deploy our software in OpenShift environment. However, our primary custom resource would get random annotations assigned , e.g.,
The resource name and resource type would change randomly after each deployment.
After some debugging, it looks like
handler.SetOwnerAnnotations()
's arguments are in reverse.The caller:
The function:
This PR fixes the issue by correcting the order of arguments.
Checklist
If the pull request includes user-facing changes, extra documentation is required:
changelog/fragments
(seechangelog/fragments/00-template.yaml
)website/content/en/docs