Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feedback Needed] Add service scatter chart #3201

Closed
wants to merge 2 commits into from

Conversation

tacigar
Copy link
Member

@tacigar tacigar commented Sep 6, 2020

This is a chart showing the distribution of the duration, span count and start time of the trace search results.
It also indicates by color whether the trace contains error spans or not.

スクリーンショット 2020-09-06 11 43 59

service-scatter-chart

I like this chart because it allows me to understand the search results at a glance.
But I know that some people feel this complicated.

I have created a PR for more discussion.
I'd appreciate it if you could try it out and give me feedback.

Related: #2636

@codefromthecrypt
Copy link
Member

I think we have discussed this in a few threads so far. I would like to hear from an end user why this is important enough to add. You have recently bought simplicity back, but we should choose where to spend it.

@openzipkin/core I think we should stop adding new features until we get feedback from other sites and end users. Please help curate feedback as it is often only @tacigar and folks who formerly ran sites, but don't anymore. While glad folks not running sites are happy to help, and we should also do this, it is troubling we are working with less feedback from end users recently as this is a bad pattern.

FWIW on this, I think the red button is too loud and something that hints visually what this does would be better, such as a graph. 💹

@codefromthecrypt codefromthecrypt added the rule-of-three Waiting for at least 3 thumbs up from users who aren't co-employed label Sep 7, 2020
@jorgheymans
Copy link
Contributor

I think Lens should excel in 2 parts: 1) finding a trace, and 2) making sense of said trace. Lets focus on this and make these bits really great.

A graphical representation of a collection of traces could be useful but is hard to get right and does not always lead to finding a trace quicker. Also it gives the false impression (to me at least) we're venturing into metrics land.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feedback-needed rule-of-three Waiting for at least 3 thumbs up from users who aren't co-employed ui Zipkin UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants