Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vsftpd: handle migration and fix secure_chroot_dir error #25720

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

mhusaam
Copy link
Contributor

@mhusaam mhusaam commented Jan 10, 2025

  • update UCI to use the traditional vsftpd.conf so that people migrating from non-uci version do not face problems
  • if secure_chroot_dir is not provided specifically, then create an empty directory where vsftpd usually expects it

Signed-off-by: Mohd Husaam Mehdi [email protected]

* update UCI to use the traditional vsftpd.conf so
  that people migrating from non-uci version do not face problems
* if secure_chroot_dir is not provided specifically, then create
  an empty directory where vsftpd usually expects it

Signed-off-by: Mohd Husaam Mehdi <[email protected]>
@feckert
Copy link
Member

feckert commented Jan 10, 2025

LGTM

@Alexey71 Can you check this changes?

Copy link

@Alexey71 Alexey71 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested. Now fine

@feckert
Copy link
Member

feckert commented Jan 10, 2025

@Alexey71 Thanks for testing
@mhusaam Thanks for fixing the issues
@BKPepe Thanks for your review

@feckert feckert merged commit e5ceb59 into openwrt:master Jan 10, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants