ddns-scripts: cloudflare: use PATCH method, minimize changes #25711
+4
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
need to bump PKG_RELEASE |
gadall
force-pushed
the
cloudflare-ddns-patch
branch
from
5a8caaf to
a96ec69
Compare
|
@neheb Thanks |
Using the PUT method recreates the DNS record with and only with the newly provided data. This seems unnecessary. In particular, we don't need to hardcode a TTL of 120. Any existing comment would be lost too. The only detail we need to change is the IP address. Leave everything else as it was. Signed-off-by: Gedalya Nie <[email protected]>
gadall
force-pushed
the
cloudflare-ddns-patch
branch
from
a96ec69 to
99dddb8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maintainer: me
Compile tested: none, shell-only
Run tested: mediatek/mt7622, aarch64_cortex-a53, Linksys E8450 (UBI), SNAPSHOT r0-285bdd2, tested updating A record to the current IPv4 address
Description:
Use the PATCH method which is the intended way to update an existing record with the cloudflare API, and update the "content" (rdata) only, that is, the IP address, leaving any other existing details intact.
In particular this removes the hard-coded 120 second TTL overriding the existing value set at cloudflare.