Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fscrypt: add new package #25706

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fscrypt: add new package #25706

wants to merge 1 commit into from

Conversation

graysky2
Copy link
Contributor

@graysky2 graysky2 commented Jan 8, 2025

Fscrypt is a high-level tool for the management of Linux native filesystem encryption. fscrypt manages metadata, key generation, key wrapping, PAM integration, and provides a uniform interface for creating and modifying encrypted directories.

Upstream url: https://github.com/google/fscrypt/blob/master/README.md

Build system: x86/64
Build-tested: bcm27xx/bcm2712
Run-tested: bcm27xx/bcm2712

Maintainer: me

@Rondom
Copy link
Contributor

Rondom commented Jan 9, 2025

Have you considered packaging fscryptctl as well? It is a bit more lightweight and might be better suited for small flash targets. https://github.com/google/fscryptctl

@graysky2
Copy link
Contributor Author

graysky2 commented Jan 9, 2025

I have no experience with it whereas I have been using fscrypt for a while now. I think both could be valuable additions to the available software. In my case, I am running this on x86/64 and an bcm2712 and neither machines are rootfs space limited. Let's see how the uptake of this package goes with those able to merge.

@graysky2
Copy link
Contributor Author

graysky2 commented Jan 9, 2025

@Rondom - do you have a use case for fscryptctl and would you be willing to test it out if I spin up a Makefile for it?

@Rondom
Copy link
Contributor

Rondom commented Jan 9, 2025

Sure

@graysky2
Copy link
Contributor Author

graysky2 commented Jan 9, 2025

This builds and runs for me. Please try it out: #25716

Copy link
Member

@BKPepe BKPepe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need to have two packages, which does the same thing? Choose which one do you really need - if this one or #25716, because I can not accept such packages, if there is a lot of unmaintained packages already and we dont have simply manpower to handle this.

@graysky2
Copy link
Contributor Author

graysky2 commented Jan 9, 2025

This package is the more feature-rich supporting passphrases and keys. I use this not the other. BTW, I have no plans to abandon maintainership.

@BKPepe
Copy link
Member

BKPepe commented Jan 9, 2025

Well, I was speaking more generally like in this repo, there is a lot of packages, which are not maintained, used, updated including mine, though. But if you are not going to use the other one, then we can keep only this one and thats it. :)

utils/fscrypt/Makefile Outdated Show resolved Hide resolved
utils/fscrypt/Makefile Outdated Show resolved Hide resolved
utils/fscrypt/Makefile Outdated Show resolved Hide resolved
utils/fscrypt/Makefile Outdated Show resolved Hide resolved
utils/fscrypt/Makefile Outdated Show resolved Hide resolved
@Rondom
Copy link
Contributor

Rondom commented Jan 9, 2025

We definitely have a need for fscryptctl and will use it / are using it. The two tools fulfill overlapping but slightly different purposes. Fscryptctl is low-level and can be used in boot scripts to unlock encrypted file systems using plain leys. fscrypt, on the other hand, has password support and key derivation on top and other niceties.

@graysky2 graysky2 force-pushed the fscrypt branch 3 times, most recently from 2c88876 to 446d5af Compare January 10, 2025 02:37
@@ -0,0 +1,57 @@
include $(TOPDIR)/rules.mk
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this Makefile need a license, similar to other package Makefiles in this repo? (SPDX line)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure, seems like a mixed-bag in the Makefile here

utils/fscrypt/Makefile Outdated Show resolved Hide resolved
utils/fscrypt/Makefile Outdated Show resolved Hide resolved
Fscrypt is a high-level tool for the management of Linux native
filesystem encryption. fscrypt manages metadata, key generation, key
wrapping, PAM integration, and provides a uniform interface for creating
and modifying encrypted directories.

Upstream url: https://github.com/google/fscrypt/blob/master/README.md

Build system: x86/64
Build-tested: bcm27xx/bcm2712
Run-tested: bcm27xx/bcm2712

Signed-off-by: John Audia <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants