coremark: fix error when it was built in the second run #25569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when there is an error building packages(other than coremark), and re-run with make -j1 V=s, the coremark package will report error ``` mkdir: cannot create directory '.../coremark-d5fad6bd094899101a4e5fd53af7298160ced6ab/aarch64': File exists ``` so, add a check to see if that dir is already there; this is due to the fact that, in the second run, that folder is already created in the first run, and not removed before the second run. also, add a '/' to the destination folder of the cp command, otherwise it will also report a "file exist" error. the '-r' is also removed, since $(CP) already have -r fixes immortalwrt/packages#1380 P.S. I'm not sure if this can be done by move the "mkdir" to `Build/Prepare` or `Build/Configure`, cause I'm not quite familiar with the Openwrt build system, so any comment is warmly welcome. Signed-off-by: xlighting2017 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maintainer: @abajk
Compile tested: (aarch64, qualcommax, SNAPSHOT)
Run tested: (aarch64, qualcommax, SNAPSHOT, tests done)
Description:
when there is an error building packages(other than coremark), and re-run with make -j1 V=s, the coremark package will report error
so, add a check to see if that dir is already there;
the root cause is that, in the second run, that folder is already created in the first run, and not removed before the second run.
also, add a '/' to the destination folder of the cp command, otherwise it will also report a "file exist" error.
the '-r' is also removed, since $(CP) already have -r
fixes immortalwrt/packages#1380
P.S. I'm not sure if this can be done by move the "mkdir" to
Build/PrepareorBuild/Configure, cause I'm not quite familiar with the Openwrt build system, so any comment is warmly welcome.